Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-1830] Replaced bigint literals with BigInt #684

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

marco-saia-datadog
Copy link
Member

What does this PR do?

Replaces bigint literals with BigInt objects, because React Native does not grant full support for bigint literals, making the iOS bundling step fail.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-1830/128-bit-trace-ids branch from 2becba3 to 78a1d49 Compare July 4, 2024 14:11
@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review July 4, 2024 14:58
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner July 4, 2024 14:58
@marco-saia-datadog marco-saia-datadog merged commit 13fe986 into develop Jul 4, 2024
6 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUM-1830/128-bit-trace-ids branch July 4, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants