-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Fody from 6.8.1 to 6.9.1 in /tracer/src/Datadog.Trace.BenchmarkDotNet #6321
base: master
Are you sure you want to change the base?
Bump Fody from 6.8.1 to 6.9.1 in /tracer/src/Datadog.Trace.BenchmarkDotNet #6321
Conversation
Bumps [Fody](https://github.com/Fody/Fody) from 6.8.1 to 6.9.1. - [Release notes](https://github.com/Fody/Fody/releases) - [Commits](Fody/Fody@6.8.1...6.9.1) --- updated-dependencies: - dependency-name: Fody dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6321) - mean (71ms) : 64, 78
. : milestone, 71,
master - mean (72ms) : 64, 79
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6321) - mean (1,111ms) : 1093, 1129
. : milestone, 1111,
master - mean (1,107ms) : 1090, 1125
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6321) - mean (109ms) : 106, 113
. : milestone, 109,
master - mean (109ms) : 106, 111
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (6321) - mean (775ms) : 759, 791
. : milestone, 775,
master - mean (768ms) : 753, 782
. : milestone, 768,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6321) - mean (92ms) : 90, 95
. : milestone, 92,
master - mean (92ms) : 89, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6321) - mean (726ms) : 710, 742
. : milestone, 726,
master - mean (724ms) : 710, 738
. : milestone, 724,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6321) - mean (191ms) : 187, 196
. : milestone, 191,
master - mean (191ms) : 183, 200
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6321) - mean (1,215ms) : 1199, 1231
. : milestone, 1215,
master - mean (1,210ms) : 1186, 1234
. : milestone, 1210,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6321) - mean (277ms) : 274, 280
. : milestone, 277,
master - mean (276ms) : 272, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6321) - mean (948ms) : 930, 967
. : milestone, 948,
master - mean (947ms) : 927, 967
. : milestone, 947,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6321) - mean (267ms) : 263, 270
. : milestone, 267,
master - mean (266ms) : 261, 270
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (6321) - mean (932ms) : 918, 947
. : milestone, 932,
master - mean (930ms) : 912, 949
. : milestone, 930,
|
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 444275 Passed, 2546 Skipped, 18h 38m 20.13s Total Time ❌ Failed Tests (1)
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6321) (11.127M) : 0, 11126750
master (10.953M) : 0, 10953423
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6321) (7.249M) : 0, 7249222
master (7.258M) : 0, 7258128
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.591M) : 0, 7590970
section Manual
master (11.208M) : 0, 11207771
section Manual + Automatic
This PR (6321) (6.644M) : 0, 6643760
master (6.722M) : 0, 6721955
section DD_TRACE_ENABLED=0
master (10.178M) : 0, 10178373
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6321) (9.414M) : 0, 9414298
master (9.269M) : 0, 9268938
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6321) (6.480M) : 0, 6480415
master (6.299M) : 0, 6299432
section Trace stats
master (6.605M) : 0, 6605300
section Manual
master (9.212M) : 0, 9211628
section Manual + Automatic
This PR (6321) (6.012M) : 0, 6011873
master (5.797M) : 0, 5796944
section DD_TRACE_ENABLED=0
master (8.676M) : 0, 8675777
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6321) (9.276M) : 0, 9275719
master (9.183M) : 0, 9182720
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6321) (5.960M) : 0, 5960006
master (6.143M) : 0, 6143036
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.605M) : 0, 6604886
section Manual
master (9.047M) : 0, 9046916
section Manual + Automatic
This PR (6321) (5.663M) : 0, 5662969
master (5.730M) : 0, 5730049
section DD_TRACE_ENABLED=0
master (8.828M) : 0, 8828238
|
Benchmarks Report for tracer 🐌Benchmarks for #6321 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 | 1.217 | 1,175.48 | 1,430.00 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.22μs | 0.535ns | 1.93ns | 0.0135 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.57μs | 0.821ns | 3.07ns | 0.0133 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.59μs | 1.2ns | 4.47ns | 0.157 | 0 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.18μs | 0.626ns | 2.43ns | 0.0135 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.64μs | 0.647ns | 2.33ns | 0.0139 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.69μs | 6ns | 23.2ns | 0.167 | 0 | 0 | 1.05 KB |
#6321 | CallElasticsearch |
net6.0 | 1.23μs | 0.634ns | 2.46ns | 0.0136 | 0 | 0 | 976 B |
#6321 | CallElasticsearch |
netcoreapp3.1 | 1.53μs | 1.33ns | 4.97ns | 0.013 | 0 | 0 | 976 B |
#6321 | CallElasticsearch |
net472 | 2.59μs | 11.5ns | 44.4ns | 0.158 | 0 | 0 | 995 B |
#6321 | CallElasticsearchAsync |
net6.0 | 1.43μs | 0.839ns | 3.25ns | 0.0129 | 0 | 0 | 952 B |
#6321 | CallElasticsearchAsync |
netcoreapp3.1 | 1.63μs | 1.12ns | 4.19ns | 0.0139 | 0 | 0 | 1.02 KB |
#6321 | CallElasticsearchAsync |
net472 | 2.53μs | 2.66ns | 9.94ns | 0.167 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.37μs | 0.791ns | 2.85ns | 0.0137 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.69μs | 2.1ns | 7.87ns | 0.0126 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.77μs | 0.43ns | 1.55ns | 0.145 | 0 | 0 | 915 B |
#6321 | ExecuteAsync |
net6.0 | 1.31μs | 1.25ns | 4.84ns | 0.0135 | 0 | 0 | 952 B |
#6321 | ExecuteAsync |
netcoreapp3.1 | 1.64μs | 0.488ns | 1.76ns | 0.013 | 0 | 0 | 952 B |
#6321 | ExecuteAsync |
net472 | 1.79μs | 0.517ns | 1.94ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.31μs | 2.13ns | 7.98ns | 0.0326 | 0 | 0 | 2.31 KB |
master | SendAsync |
netcoreapp3.1 | 5.38μs | 2.11ns | 8.16ns | 0.0377 | 0 | 0 | 2.85 KB |
master | SendAsync |
net472 | 7.4μs | 2.23ns | 8.65ns | 0.494 | 0 | 0 | 3.12 KB |
#6321 | SendAsync |
net6.0 | 4.34μs | 1.68ns | 6.28ns | 0.0326 | 0 | 0 | 2.31 KB |
#6321 | SendAsync |
netcoreapp3.1 | 5.34μs | 1.89ns | 7.33ns | 0.0375 | 0 | 0 | 2.85 KB |
#6321 | SendAsync |
net472 | 7.33μs | 3.88ns | 15ns | 0.495 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.57μs | 0.836ns | 3.13ns | 0.0229 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.22μs | 0.871ns | 3.14ns | 0.0221 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.57μs | 1.07ns | 4.01ns | 0.249 | 0 | 0 | 1.57 KB |
#6321 | EnrichedLog |
net6.0 | 1.46μs | 0.928ns | 3.47ns | 0.0235 | 0 | 0 | 1.64 KB |
#6321 | EnrichedLog |
netcoreapp3.1 | 2.19μs | 1.02ns | 3.95ns | 0.0219 | 0 | 0 | 1.64 KB |
#6321 | EnrichedLog |
net472 | 2.54μs | 2.33ns | 9.03ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 119μs | 126ns | 489ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 124μs | 89.6ns | 323ns | 0.0622 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 153μs | 325ns | 1.26μs | 0.692 | 0.231 | 0 | 4.46 KB |
#6321 | EnrichedLog |
net6.0 | 119μs | 143ns | 552ns | 0 | 0 | 0 | 4.28 KB |
#6321 | EnrichedLog |
netcoreapp3.1 | 123μs | 91.6ns | 355ns | 0.0618 | 0 | 0 | 4.28 KB |
#6321 | EnrichedLog |
net472 | 152μs | 123ns | 462ns | 0.682 | 0.227 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.99μs | 1.03ns | 4ns | 0.0315 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.13μs | 2.2ns | 7.95ns | 0.0289 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 4.87μs | 1.83ns | 7.08ns | 0.32 | 0 | 0 | 2.02 KB |
#6321 | EnrichedLog |
net6.0 | 2.89μs | 1.19ns | 4.61ns | 0.0307 | 0 | 0 | 2.2 KB |
#6321 | EnrichedLog |
netcoreapp3.1 | 4.18μs | 1.43ns | 5.36ns | 0.0293 | 0 | 0 | 2.2 KB |
#6321 | EnrichedLog |
net472 | 4.82μs | 1.35ns | 5.21ns | 0.319 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.29μs | 0.556ns | 2.15ns | 0.0159 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.79μs | 2.8ns | 10.8ns | 0.0152 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.09μs | 0.988ns | 3.83ns | 0.184 | 0 | 0 | 1.16 KB |
#6321 | SendReceive |
net6.0 | 1.37μs | 1.28ns | 4.96ns | 0.0157 | 0 | 0 | 1.14 KB |
#6321 | SendReceive |
netcoreapp3.1 | 1.79μs | 1.47ns | 5.52ns | 0.0151 | 0 | 0 | 1.14 KB |
#6321 | SendReceive |
net472 | 2.1μs | 3.17ns | 12.3ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.7μs | 0.705ns | 2.64ns | 0.0216 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.99μs | 1.08ns | 3.9ns | 0.0222 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.47μs | 3.03ns | 11.7ns | 0.324 | 0 | 0 | 2.04 KB |
#6321 | EnrichedLog |
net6.0 | 2.7μs | 0.863ns | 3.23ns | 0.0216 | 0 | 0 | 1.6 KB |
#6321 | EnrichedLog |
netcoreapp3.1 | 3.95μs | 6.69ns | 25.9ns | 0.0217 | 0 | 0 | 1.65 KB |
#6321 | EnrichedLog |
net472 | 4.47μs | 6.22ns | 24.1ns | 0.324 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6321
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0
1.115
453.29
406.64
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.115 | 453.29 | 406.64 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 452ns | 0.784ns | 3.03ns | 0.00815 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 595ns | 1.21ns | 4.7ns | 0.00785 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 659ns | 1.25ns | 4.83ns | 0.0916 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 484ns | 0.751ns | 2.91ns | 0.00985 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 768ns | 1.32ns | 5.11ns | 0.00953 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 845ns | 2.72ns | 10.5ns | 0.105 | 0 | 0 | 658 B |
#6321 | StartFinishSpan |
net6.0 | 406ns | 0.47ns | 1.82ns | 0.00801 | 0 | 0 | 576 B |
#6321 | StartFinishSpan |
netcoreapp3.1 | 593ns | 0.454ns | 1.76ns | 0.00787 | 0 | 0 | 576 B |
#6321 | StartFinishSpan |
net472 | 658ns | 2.02ns | 7.81ns | 0.0917 | 0 | 0 | 578 B |
#6321 | StartFinishScope |
net6.0 | 483ns | 0.628ns | 2.43ns | 0.00989 | 0 | 0 | 696 B |
#6321 | StartFinishScope |
netcoreapp3.1 | 740ns | 1.21ns | 4.68ns | 0.00952 | 0 | 0 | 696 B |
#6321 | StartFinishScope |
net472 | 862ns | 4.17ns | 16.7ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 599ns | 1.38ns | 5.35ns | 0.00976 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 898ns | 1.15ns | 4.46ns | 0.00942 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.04μs | 2.57ns | 9.96ns | 0.104 | 0 | 0 | 658 B |
#6321 | RunOnMethodBegin |
net6.0 | 651ns | 1.09ns | 4.23ns | 0.00978 | 0 | 0 | 696 B |
#6321 | RunOnMethodBegin |
netcoreapp3.1 | 999ns | 1.33ns | 5.14ns | 0.00943 | 0 | 0 | 696 B |
#6321 | RunOnMethodBegin |
net472 | 1.14μs | 3.01ns | 11.7ns | 0.104 | 0 | 0 | 658 B |
Bumps Fody from 6.8.1 to 6.9.1.
Release notes
Sourced from Fody's releases.
Commits
7fb7371
Merge pull request #1305 from Fody/dev/packagereadme8fa59df
V 6.9.16941564
Update dependenciesc6b7b56
Aktualisieren von package_readme.mdb1355f0
Embed a simplified readme in the nuget packagecd5ab0f
Embed the icon in the Fody package5519b9b
v6.9.08751903
Bump test assembliesf9d0ff0
Merge pull request #1304 from Fody/update-cecil4c6e631
Update net6.0 to net8.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)