Anna/asm/add sessionid beginning request #6623

anna-git · 2025-02-03T16:56:44Z

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging · 2025-02-03T17:19:26Z

Datadog Report

Branch report: anna/asm/add-sessionid-beginning-request
Commit report: b9e859b
Test service: dd-trace-dotnet

❌ 121 Failed (0 Known Flaky), 244485 Passed, 2226 Skipped, 18h 48m 39.81s Total Time

❌ Failed Tests (121)

This report shows up to 5 failed tests.

TestAuthenticatedRequest - Datadog.Trace.Security.IntegrationTests.AspNetCore5AutoUserEventsDefaultModeSecurityEnabled - Details

Expand for error

 Results do not match.
 Differences:
 Received: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.received.txt
 Verified: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: aspnet_core.request,
 ...

TestAuthenticatedRequest - Datadog.Trace.Security.IntegrationTests.AspNetCore5AutoUserEventsDefaultModeSecurityEnabled - Details

Expand for error

 Results do not match.
 Differences:
 Received: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.received.txt
 Verified: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: aspnet_core.request,
 ...

TestAuthenticatedRequest - Datadog.Trace.Security.IntegrationTests.AspNetCore5AutoUserEventsDefaultModeSecurityEnabled - Details

Expand for error

 Results do not match.
 Differences:
 Received: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.received.txt
 Verified: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: aspnet_core.request,
 ...

TestAuthenticatedRequest - Datadog.Trace.Security.IntegrationTests.AspNetCore5AutoUserEventsDefaultModeSecurityEnabled - Details

Expand for error

 Results do not match.
 Differences:
 Received: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.received.txt
 Verified: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: aspnet_core.request,
 ...

TestAuthenticatedRequest - Datadog.Trace.Security.IntegrationTests.AspNetCore5AutoUserEventsDefaultModeSecurityEnabled - Details

Expand for error

 Results do not match.
 Differences:
 Received: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.received.txt
 Verified: Security.AspNetCore5AutoUserEvents.SecurityOn.defaultmode-TestAuthenticatedRequest.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: aspnet_core.request,
 ...

andrewlock · 2025-02-03T17:44:29Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (69ms)  : 66, 73
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (993ms)  : 964, 1021
     .   : milestone, 993,
    master - mean (990ms)  : 966, 1013
     .   : milestone, 990,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (103ms)  : 101, 105
     .   : milestone, 103,
    master - mean (103ms)  : 100, 105
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (670ms)  : 655, 685
     .   : milestone, 670,
    master - mean (674ms)  : 658, 689
     .   : milestone, 674,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (90ms)  : 88, 92
     .   : milestone, 90,
    master - mean (89ms)  : 88, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (633ms)  : 619, 647
     .   : milestone, 633,
    master - mean (636ms)  : 614, 659
     .   : milestone, 636,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (190ms)  : 187, 194
     .   : milestone, 190,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (1,098ms)  : 1068, 1129
     .   : milestone, 1098,
    master - mean (1,105ms)  : 1074, 1136
     .   : milestone, 1105,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (270ms)  : 265, 274
     .   : milestone, 270,
    master - mean (269ms)  : 266, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (861ms)  : 832, 891
     .   : milestone, 861,
    master - mean (865ms)  : 833, 896
     .   : milestone, 865,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6623) - mean (262ms)  : 257, 267
     .   : milestone, 262,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (6623) - mean (841ms)  : 806, 876
     .   : milestone, 841,
    master - mean (853ms)  : 823, 884
     .   : milestone, 853,

andrewlock · 2025-02-03T18:24:37Z

Benchmarks Report for appsec 🐌

Benchmarks for #6623 compared to master:

1 benchmarks are faster, with geometric mean 1.837
1 benchmarks have fewer allocations
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	202μs	159ns	615ns	2.63	0	191.07 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	310μs	105ns	394ns	2.62	0	198.5 KB
master	`AllCycleSimpleBody`	net472	270μs	182ns	629ns	36.3	2.03	228.82 KB
master	`AllCycleMoreComplexBody`	net6.0	213μs	96.7ns	362ns	2.76	0	194.58 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	313μs	120ns	449ns	2.66	0	201.91 KB
master	`AllCycleMoreComplexBody`	net472	277μs	172ns	644ns	36.9	2.07	232.33 KB
master	`ObjectExtractorSimpleBody`	net6.0	152ns	0.123ns	0.458ns	0.00396	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	210ns	0.586ns	2.27ns	0.00373	0	272 B
master	`ObjectExtractorSimpleBody`	net472	168ns	0.168ns	0.651ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	2.93μs	1.54ns	5.95ns	0.0532	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.8μs	1.39ns	5.21ns	0.0513	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	3.65μs	2.6ns	10.1ns	0.601	0.00545	3.8 KB
#6623	`AllCycleSimpleBody`	net6.0	206μs	104ns	389ns	2.69	0	191.07 KB
#6623	`AllCycleSimpleBody`	netcoreapp3.1	306μs	135ns	522ns	2.63	0	198.5 KB
#6623	`AllCycleSimpleBody`	net472	272μs	105ns	395ns	36.2	2.05	228.82 KB
#6623	`AllCycleMoreComplexBody`	net6.0	213μs	100ns	374ns	2.75	0	194.58 KB
#6623	`AllCycleMoreComplexBody`	netcoreapp3.1	318μs	159ns	614ns	2.68	0	201.91 KB
#6623	`AllCycleMoreComplexBody`	net472	282μs	70.5ns	273ns	36.8	2.13	232.33 KB
#6623	`ObjectExtractorSimpleBody`	net6.0	156ns	0.125ns	0.467ns	0.00393	0	280 B
#6623	`ObjectExtractorSimpleBody`	netcoreapp3.1	211ns	0.131ns	0.49ns	0.0037	0	272 B
#6623	`ObjectExtractorSimpleBody`	net472	169ns	0.126ns	0.436ns	0.0446	0	281 B
#6623	`ObjectExtractorMoreComplexBody`	net6.0	2.95μs	0.836ns	3.13ns	0.0532	0	3.78 KB
#6623	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.76μs	2.27ns	8.19ns	0.0492	0	3.69 KB
#6623	`ObjectExtractorMoreComplexBody`	net472	3.67μs	3.13ns	11.7ns	0.602	0.00551	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EncodeArgs`	net6.0	38.6μs	16.9ns	65.5ns	0.466	0	32.4 KB
master	`EncodeArgs`	netcoreapp3.1	53.8μs	27.2ns	105ns	0.428	0	32.4 KB
master	`EncodeArgs`	net472	66μs	65.6ns	254ns	5.15	0.066	32.5 KB
master	`EncodeLegacyArgs`	net6.0	75.6μs	30ns	112ns	0	0	2.14 KB
master	`EncodeLegacyArgs`	netcoreapp3.1	106μs	44.2ns	171ns	0	0	2.14 KB
master	`EncodeLegacyArgs`	net472	151μs	111ns	430ns	0.302	0	2.15 KB
#6623	`EncodeArgs`	net6.0	37.5μs	14.5ns	54.4ns	0.452	0	32.4 KB
#6623	`EncodeArgs`	netcoreapp3.1	54.9μs	27.8ns	104ns	0.437	0	32.4 KB
#6623	`EncodeArgs`	net472	68.3μs	80ns	310ns	5.14	0.068	32.5 KB
#6623	`EncodeLegacyArgs`	net6.0	72.1μs	19.4ns	72.8ns	0	0	2.14 KB
#6623	`EncodeLegacyArgs`	netcoreapp3.1	103μs	79.7ns	309ns	0	0	2.14 KB
#6623	`EncodeLegacyArgs`	net472	152μs	87.3ns	338ns	0.302	0	2.15 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunWafRealisticBenchmark`	net6.0	174μs	82.5ns	320ns	0	2.54 KB
master	`RunWafRealisticBenchmark`	netcoreapp3.1	188μs	68.5ns	256ns	0	2.49 KB
master	`RunWafRealisticBenchmark`	net472	199μs	114ns	426ns	0.399	2.55 KB
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	116μs	102ns	396ns	0	1.57 KB
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	123μs	185ns	718ns	0	1.55 KB
master	`RunWafRealisticBenchmarkWithAttack`	net472	133μs	43.5ns	168ns	0.198	1.58 KB
#6623	`RunWafRealisticBenchmark`	net6.0	175μs	175ns	676ns	0	2.54 KB
#6623	`RunWafRealisticBenchmark`	netcoreapp3.1	186μs	293ns	1.13μs	0	2.49 KB
#6623	`RunWafRealisticBenchmark`	net472	203μs	74.7ns	289ns	0.4	2.55 KB
#6623	`RunWafRealisticBenchmarkWithAttack`	net6.0	115μs	31.1ns	112ns	0	1.57 KB
#6623	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	123μs	110ns	411ns	0	1.55 KB
#6623	`RunWafRealisticBenchmarkWithAttack`	net472	133μs	49.4ns	185ns	0.199	1.58 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #6623

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	1.837	625,700.00	340,700.00	several?

More allocations ⚠️ in #6623

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	253.78 KB	265.23 KB	11.46 KB	4.51%

Fewer allocations 🎉 in #6623

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	316.12 KB	253.98 KB	-62.14 KB	-19.66%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	60.4μs	836ns	8.36μs	43.44 KB
master	`StringConcatBenchmark`	netcoreapp3.1	61.8μs	664ns	6.47μs	42.64 KB
master	`StringConcatBenchmark`	net472	37.5μs	78.9ns	295ns	59.62 KB
master	`StringConcatAspectBenchmark`	net6.0	312μs	1.53μs	9.94μs	253.78 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	629μs	3.43μs	21.1μs	316.12 KB
master	`StringConcatAspectBenchmark`	net472	294μs	6.74μs	66.7μs	278.53 KB
#6623	`StringConcatBenchmark`	net6.0	59μs	631ns	6.28μs	43.44 KB
#6623	`StringConcatBenchmark`	netcoreapp3.1	55.4μs	289ns	1.53μs	42.64 KB
#6623	`StringConcatBenchmark`	net472	37.1μs	51.4ns	185ns	59.62 KB
#6623	`StringConcatAspectBenchmark`	net6.0	327μs	1.72μs	9.89μs	265.23 KB
#6623	`StringConcatAspectBenchmark`	netcoreapp3.1	341μs	1.61μs	7.88μs	253.98 KB
#6623	`StringConcatAspectBenchmark`	net472	297μs	6.11μs	60.2μs	278.53 KB

andrewlock · 2025-02-03T23:46:30Z

Benchmarks Report for tracer 🐌

Benchmarks for #6623 compared to master:

1 benchmarks are slower, with geometric mean 1.112
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.92μs	42.6ns	344ns	0.0115	0.00384	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	57ns	407ns	0.0201	0.0101	0	5.8 KB
master	`StartStopWithChild`	net472	15.9μs	44.2ns	171ns	1.06	0.341	0.103	6.21 KB
#6623	`StartStopWithChild`	net6.0	8.02μs	45.5ns	325ns	0.0128	0.00425	0	5.6 KB
#6623	`StartStopWithChild`	netcoreapp3.1	10.5μs	55.9ns	285ns	0.0255	0.0102	0	5.8 KB
#6623	`StartStopWithChild`	net472	16μs	58.9ns	228ns	1.04	0.305	0.0964	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	498μs	116ns	419ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	638μs	422ns	1.58μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	842μs	833ns	3.12μs	0.419	3.3 KB
#6623	`WriteAndFlushEnrichedTraces`	net6.0	496μs	522ns	2.02μs	0	2.7 KB
#6623	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	599ns	2.32μs	0	2.7 KB
#6623	`WriteAndFlushEnrichedTraces`	net472	849μs	776ns	3.01μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	127μs	380ns	1.42μs	0.189	14.47 KB
master	`SendRequest`	netcoreapp3.1	142μs	460ns	1.78μs	0.208	17.27 KB
master	`SendRequest`	net472	0.00282ns	0.00118ns	0.00456ns	0	0 b
#6623	`SendRequest`	net6.0	130μs	582ns	2.26μs	0.197	14.47 KB
#6623	`SendRequest`	netcoreapp3.1	144μs	499ns	1.93μs	0.213	17.27 KB
#6623	`SendRequest`	net472	0.00149ns	0.000379ns	0.00147ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6623

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.42 KB	41.72 KB	297 B	0.72%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	574μs	3.28μs	25.2μs	0.551	0	0	41.42 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	680μs	3.9μs	30.5μs	0.314	0	0	41.71 KB
master	`WriteAndFlushEnrichedTraces`	net472	831μs	3.38μs	13.1μs	8.39	2.52	0.419	53.26 KB
#6623	`WriteAndFlushEnrichedTraces`	net6.0	590μs	2.41μs	9.02μs	0.607	0	0	41.72 KB
#6623	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	663μs	3.63μs	22.4μs	0.324	0	0	41.82 KB
#6623	`WriteAndFlushEnrichedTraces`	net472	849μs	4.56μs	23.7μs	8.33	2.5	0.417	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.26μs	0.905ns	3.39ns	0.0144	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.81μs	1.63ns	6.1ns	0.0135	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.14μs	1.87ns	7.25ns	0.157	0.00107	987 B
#6623	`ExecuteNonQuery`	net6.0	1.27μs	1.03ns	3.98ns	0.0139	0	1.02 KB
#6623	`ExecuteNonQuery`	netcoreapp3.1	1.8μs	3.02ns	11.7ns	0.0137	0	1.02 KB
#6623	`ExecuteNonQuery`	net472	2.09μs	1.19ns	4.62ns	0.156	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.26μs	0.574ns	2.22ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.52μs	0.577ns	2.16ns	0.013	976 B
master	`CallElasticsearch`	net472	2.52μs	3.19ns	11.9ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.32μs	0.597ns	2.31ns	0.0132	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.72μs	0.832ns	3.11ns	0.0137	1.02 KB
master	`CallElasticsearchAsync`	net472	2.69μs	1.17ns	4.2ns	0.167	1.05 KB
#6623	`CallElasticsearch`	net6.0	1.23μs	0.306ns	1.15ns	0.0136	976 B
#6623	`CallElasticsearch`	netcoreapp3.1	1.5μs	0.816ns	3.05ns	0.0128	976 B
#6623	`CallElasticsearch`	net472	2.57μs	1.71ns	6.39ns	0.158	995 B
#6623	`CallElasticsearchAsync`	net6.0	1.26μs	0.29ns	1.04ns	0.0132	952 B
#6623	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.512ns	1.91ns	0.0138	1.02 KB
#6623	`CallElasticsearchAsync`	net472	2.68μs	1.96ns	7.58ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.22μs	0.572ns	2.14ns	0.0135	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.61μs	0.889ns	3.33ns	0.0122	952 B
master	`ExecuteAsync`	net472	1.82μs	0.307ns	1.19ns	0.145	915 B
#6623	`ExecuteAsync`	net6.0	1.33μs	1.28ns	4.79ns	0.0133	952 B
#6623	`ExecuteAsync`	netcoreapp3.1	1.63μs	0.512ns	1.85ns	0.0124	952 B
#6623	`ExecuteAsync`	net472	1.8μs	0.773ns	2.89ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.49μs	1.74ns	6.52ns	0.0315	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.2μs	1.7ns	6.59ns	0.0397	2.85 KB
master	`SendAsync`	net472	7.44μs	1.6ns	6.21ns	0.495	3.12 KB
#6623	`SendAsync`	net6.0	4.3μs	1.68ns	6.3ns	0.0324	2.31 KB
#6623	`SendAsync`	netcoreapp3.1	5.3μs	4.59ns	17.8ns	0.0371	2.85 KB
#6623	`SendAsync`	net472	7.41μs	1.28ns	4.78ns	0.493	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.48μs	0.836ns	3.13ns	0.0234	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.24μs	1.1ns	4.1ns	0.0212	1.64 KB
master	`EnrichedLog`	net472	2.61μs	0.618ns	2.31ns	0.249	1.57 KB
#6623	`EnrichedLog`	net6.0	1.49μs	0.673ns	2.52ns	0.0233	1.64 KB
#6623	`EnrichedLog`	netcoreapp3.1	2.17μs	1.63ns	6.09ns	0.0217	1.64 KB
#6623	`EnrichedLog`	net472	2.48μs	0.815ns	3.05ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	245ns	950ns	0.056	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	122ns	473ns	0.0585	0	4.28 KB
master	`EnrichedLog`	net472	150μs	80.2ns	311ns	0.679	0.226	4.46 KB
#6623	`EnrichedLog`	net6.0	113μs	94.4ns	366ns	0.0565	0	4.28 KB
#6623	`EnrichedLog`	netcoreapp3.1	117μs	107ns	401ns	0.0582	0	4.28 KB
#6623	`EnrichedLog`	net472	150μs	85.3ns	319ns	0.679	0.226	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3μs	12.6ns	48.7ns	0.0307	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.24μs	3.08ns	11.5ns	0.0297	2.2 KB
master	`EnrichedLog`	net472	4.89μs	1.33ns	5.16ns	0.319	2.02 KB
#6623	`EnrichedLog`	net6.0	3.1μs	1.06ns	4.11ns	0.0312	2.2 KB
#6623	`EnrichedLog`	netcoreapp3.1	4.21μs	2.15ns	8.32ns	0.0296	2.2 KB
#6623	`EnrichedLog`	net472	4.84μs	0.886ns	3.31ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.33μs	1.2ns	4.63ns	0.0159	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.81μs	2.11ns	8.18ns	0.0155	1.14 KB
master	`SendReceive`	net472	2.05μs	2.6ns	10.1ns	0.184	1.16 KB
#6623	`SendReceive`	net6.0	1.35μs	0.675ns	2.61ns	0.0162	1.14 KB
#6623	`SendReceive`	netcoreapp3.1	1.8μs	1.07ns	4.14ns	0.0154	1.14 KB
#6623	`SendReceive`	net472	2.09μs	1.86ns	7.21ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.78μs	1.22ns	4.74ns	0.0223	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.91μs	3.06ns	11.9ns	0.0215	1.65 KB
master	`EnrichedLog`	net472	4.37μs	1.56ns	5.85ns	0.322	2.04 KB
#6623	`EnrichedLog`	net6.0	2.72μs	2.64ns	10.2ns	0.0216	1.6 KB
#6623	`EnrichedLog`	netcoreapp3.1	3.92μs	1.01ns	3.92ns	0.0216	1.65 KB
#6623	`EnrichedLog`	net472	4.42μs	2.8ns	10.8ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6623

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	1.112	791.82	880.60

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	407ns	0.526ns	2.04ns	0.00812	576 B
master	`StartFinishSpan`	netcoreapp3.1	624ns	0.872ns	3.38ns	0.00772	576 B
master	`StartFinishSpan`	net472	629ns	1.15ns	4.45ns	0.0917	578 B
master	`StartFinishScope`	net6.0	466ns	0.701ns	2.72ns	0.00997	696 B
master	`StartFinishScope`	netcoreapp3.1	701ns	1.09ns	4.23ns	0.00937	696 B
master	`StartFinishScope`	net472	790ns	1.2ns	4.63ns	0.104	658 B
#6623	`StartFinishSpan`	net6.0	399ns	0.628ns	2.43ns	0.00817	576 B
#6623	`StartFinishSpan`	netcoreapp3.1	563ns	1.03ns	3.99ns	0.00761	576 B
#6623	`StartFinishSpan`	net472	586ns	1.96ns	7.05ns	0.0916	578 B
#6623	`StartFinishScope`	net6.0	476ns	0.489ns	1.89ns	0.00969	696 B
#6623	`StartFinishScope`	netcoreapp3.1	723ns	0.426ns	1.65ns	0.00941	696 B
#6623	`StartFinishScope`	net472	881ns	0.599ns	2.32ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	595ns	0.952ns	3.69ns	0.00984	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	975ns	1.2ns	4.63ns	0.00971	696 B
master	`RunOnMethodBegin`	net472	1.06μs	1.23ns	4.78ns	0.104	658 B
#6623	`RunOnMethodBegin`	net6.0	644ns	0.855ns	3.31ns	0.00987	696 B
#6623	`RunOnMethodBegin`	netcoreapp3.1	906ns	0.864ns	3.35ns	0.009	696 B
#6623	`RunOnMethodBegin`	net472	1.09μs	1.77ns	6.85ns	0.105	658 B

github-actions · 2025-02-05T18:29:14Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

12 occurrences of :

-      _dd.appsec.fp.session: ssn--bd9bce81-d0fff5a7-,
+      _dd.appsec.fp.session: ssn--bd9bce81-d0fff5a7-<SessionFp>,

82 occurrences of :

+      _dd.appsec.fp.session: ssn----<SessionFp>,

1 occurrences of :

-      _dd.appsec.fp.session: ssn-5860faf0---,
+      _dd.appsec.fp.session: ssn-5860faf0---<SessionFp>,

11 occurrences of :

-      _dd.appsec.fp.session: ssn-<fingerprint>,
+      _dd.appsec.fp.session: ssn-7bcd1c9f---<SessionFp>,

3 occurrences of :

-      _dd.appsec.fp.session: ssn-<fingerprint>,
+      _dd.appsec.fp.session: ssn-ef8eb89f---<SessionFp>,

anna-git force-pushed the anna/asm/add-sessionid-beginning-request branch 5 times, most recently from 0dcc935 to b9e859b Compare February 11, 2025 12:54

anna-git added 5 commits February 11, 2025 21:24

Add session id in scans

3ae8ba4

Scrub session for tests

ef1e036

adapt snapshots

ad246e3

adapt snapshots iast

e8b0e2b

adapt rasp screenshots

fb19024

anna-git force-pushed the anna/asm/add-sessionid-beginning-request branch from b9e859b to fb19024 Compare February 11, 2025 20:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Anna/asm/add sessionid beginning request #6623

Anna/asm/add sessionid beginning request #6623

anna-git commented Feb 3, 2025

datadog-ddstaging bot commented Feb 3, 2025 •

edited

Loading

andrewlock commented Feb 3, 2025 •

edited

Loading

andrewlock commented Feb 3, 2025 •

edited

Loading

Raw results

Raw results

Raw results

Faster 🎉 in #6623

More allocations ⚠️ in #6623

Fewer allocations 🎉 in #6623

Raw results

andrewlock commented Feb 3, 2025 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #6623

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6623

Raw results

Raw results

github-actions bot commented Feb 5, 2025 •

edited

Loading

Anna/asm/add sessionid beginning request #6623

Are you sure you want to change the base?

Anna/asm/add sessionid beginning request #6623

Conversation

anna-git commented Feb 3, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Feb 3, 2025 • edited Loading

Datadog Report

❌ Failed Tests (121)

andrewlock commented Feb 3, 2025 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Feb 3, 2025 • edited Loading

Benchmarks Report for appsec 🐌

Benchmark details

Raw results

Raw results

Raw results

Faster 🎉 in #6623

More allocations ⚠️ in #6623

Fewer allocations 🎉 in #6623

Raw results

andrewlock commented Feb 3, 2025 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6623

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6623

Raw results

Raw results

github-actions bot commented Feb 5, 2025 • edited Loading

Snapshots difference summary

datadog-ddstaging bot commented Feb 3, 2025 •

edited

Loading

andrewlock commented Feb 3, 2025 •

edited

Loading

andrewlock commented Feb 3, 2025 •

edited

Loading

andrewlock commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 5, 2025 •

edited

Loading