chore(w3c): ensure last parent id is never set to 16 zeros #2808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently when w3c tracestate headers are extracted by Datadog W3C Propagators:
p
value in the tracestate is stored inSpanContext.reparentID
.p
value is not found in the tracestate then SpanContext.reparentID (which will be used to setSpan.meta["_dd.parent_id"]
) is set to0000000000000000
.The second condition is no longer required. Datadog internal services no longer handle the case where
Span.meta["_dd.parent_id"] == 0000000000000000
.0000000000000000
is treated as an invalid value and ignored. We should avoid setting this value in client libraries.Motivation
Reviewer's Checklist
Unsure? Have a question? Request a review!