-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/tracer: fix trace_agent_url on startup log #2949
Conversation
BenchmarksBenchmark execution time: 2024-11-07 20:11:30 Comparing candidate commit 728d921 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Your comments make things extra-clear which I appreciate 😉 .
Let's just add a few more test cases to ensure the changes are robust.
Btw, would change the Motivation
section of the PR description to this, instead:
When DD_TRACE_AGENT_URL is set to a valid unix socket (e.g, unix:///var/run/datadog/apm.socket), the startup log on dd-trace-go contains:
"agent_url":"http://uds__var_run_datadog_apm.socket/v0.4/traces"
. We wanted the startup log to reflect the actual, un-normalized socket value instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more small nit 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more small nit 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, just waiting to be sure CI is green.
What does this PR do?
Updates the start up log so that it logs the correct value for "agent_url"
Motivation
When DD_TRACE_AGENT_URL is set to a valid unix socket (e.g, unix:///var/run/datadog/apm.socket), the startup log on dd-trace-go contains: "agent_url":"http://uds__var_run_datadog_apm.socket/v0.4/traces". We wanted the startup log to reflect the actual, un-normalized socket value instead.
Reviewer's Checklist
Unsure? Have a question? Request a review!