appsec: add tracer start option for appsec enablement #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new tracer start option that allows to explicitly enable or disable appsec, overriding the default activation criteria (from `DD_APPSEC_ENABLED` and remote configuration).
RomainMuller
commented
Nov 6, 2024
| @@ -660,7 +664,7 @@ func loadAgentFeatures(agentDisabled bool, agentURL *url.URL, httpClient *http.C | |||
| } | |||
| defer resp.Body.Close() | |||
| type agentConfig struct { | |||
| defaultEnv string `json:"default_env"` | |||
| DefaultEnv string `json:"default_env"` | |||
There was a problem hiding this comment.
NB - This was previously broken; as the json package cannot do anything with non-exported fields...
BenchmarksBenchmark execution time: 2024-11-06 17:42:14 Comparing candidate commit 855a63d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
darccio
approved these changes
Nov 6, 2024
| @@ -660,7 +664,7 @@ func loadAgentFeatures(agentDisabled bool, agentURL *url.URL, httpClient *http.C | |||
| } | |||
| defer resp.Body.Close() | |||
| type agentConfig struct { | |||
| defaultEnv string `json:"default_env"` | |||
| DefaultEnv string `json:"default_env"` | |||
Julio-Guerra
reviewed
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new tracer start option that allows to explicitly enable or disable appsec, overriding the default activation criteria (from
DD_APPSEC_ENABLEDand remote configuration).Motivation
There is a use-case in https://github.com/DataDog/datadog-agent where a tracer is started but AppSec features are undesirable (and unsupported) in this context. Explicitly disabling AppSec features allows to avoid emitting an AppSec startup error message when the agent's environment includes
DD_APPSEC_ENABLED=true.Reviewer's Checklist
Unsure? Have a question? Request a review!