Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI Visibility data to client stats (APMSP-1241) #2969

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

ajgajg1134
Copy link
Contributor

@ajgajg1134 ajgajg1134 commented Nov 7, 2024

What does this PR do?

Add the git commit sha if we're generating stats within a CI Visibility context

Motivation

This is added by the agent from span tags so to be consistent here we also need to add it when we calculate stats instead of the agent

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@ajgajg1134 ajgajg1134 changed the title Andrew.glaude/statsmore Add CI Visibility data to client stats Nov 7, 2024
@ajgajg1134 ajgajg1134 marked this pull request as ready for review November 7, 2024 16:11
@ajgajg1134 ajgajg1134 requested a review from a team as a code owner November 7, 2024 16:11
ddtrace/tracer/stats.go Outdated Show resolved Hide resolved
@ajgajg1134 ajgajg1134 changed the title Add CI Visibility data to client stats Add CI Visibility data to client stats (APMSP-1241) Nov 7, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2024

Benchmarks

Benchmark execution time: 2024-11-07 16:59:14

Comparing candidate commit 32ba696 in PR branch andrew.glaude/statsmore with baseline commit bebced4 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 0 unstable metrics.

scenario:BenchmarkSetTagMetric-24

  • 🟩 execution_time [-4.632ns; -3.148ns] or [-3.860%; -2.623%]

scenario:BenchmarkSetTagString-24

  • 🟩 execution_time [-6.182ns; -3.738ns] or [-5.376%; -3.250%]

@darccio darccio enabled auto-merge (squash) November 8, 2024 16:13
@darccio darccio merged commit 2991277 into main Nov 8, 2024
149 of 150 checks passed
@darccio darccio deleted the andrew.glaude/statsmore branch November 8, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants