fix(options): Don't override c.httpClient if it is set via the options #2970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents overrides to
c.httpClient
if it has been set by customers; even if the agent URL points to a unix socketMotivation
For my software to work I had to update the HTTP client of my tracer. Using the latest agent and tracer and letting other settings as default, the HTTP client override didn't work.
This is because:
c.httpClient
regardless of whether it has been previously setReviewer's Checklist
Unsure? Have a question? Request a review!