Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support valkey-go tracing #3081

Merged
merged 29 commits into from
Jan 28, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6aa8d69
Support valkey-go tracing
keisku Jan 12, 2025
fe59e6d
as per DD_APM_PEER_TAGS_AGGREGATION in agent
keisku Jan 16, 2025
26c6621
Merge branch 'main' into keisku/valkey-go-support
darccio Jan 17, 2025
9479b69
Merge remote-tracking branch 'origin' into keisku/valkey-go-support
keisku Jan 18, 2025
49ebeed
update example as per best practice
keisku Jan 18, 2025
90f6c43
fix doc
keisku Jan 18, 2025
46cacc3
fix spanName
keisku Jan 18, 2025
6d5b6f6
update contribIntegrations
keisku Jan 18, 2025
e99f4d7
rename to github.com/valkey-io/valkey-go
keisku Jan 21, 2025
4031cd7
remove App Analytics which was deprecated
keisku Jan 21, 2025
aae0a85
for consistency with the other examples
keisku Jan 21, 2025
14b4d21
remove ValkeyClientCommand* tags
keisku Jan 21, 2025
6197ac1
there is not concept of db.instance in valkey / redis
keisku Jan 21, 2025
7b7329f
remove db.type:valkey
keisku Jan 21, 2025
fca4a18
remove db.application
keisku Jan 21, 2025
e7758a3
fix valkey.raw_command behavior
keisku Jan 21, 2025
cdb4129
add db.out tag
keisku Jan 21, 2025
21434c3
typo
keisku Jan 21, 2025
27b0fec
remove valkeyotel tags
keisku Jan 23, 2025
06360d2
rename to out.db (ext.TargetDB)
keisku Jan 23, 2025
b8c5c35
remove peer.* tags
keisku Jan 23, 2025
fba84df
rework DD_TRACE_VALKEY_RAW_COMMAND behavior
keisku Jan 23, 2025
25088d1
fix error handling when a span finishes
keisku Jan 23, 2025
d9bb011
fix raw command + add missing service name option + refactor
rarguelloF Jan 27, 2025
4ab8179
Merge branch 'main' into keisku/valkey-go-support
rarguelloF Jan 27, 2025
7eeeb6c
fix: go mod tidy smoke test
keisku Jan 28, 2025
b9e6353
Merge branch 'main' into keisku/valkey-go-support
rarguelloF Jan 28, 2025
7c87d09
Merge branch 'main' into keisku/valkey-go-support
rarguelloF Jan 28, 2025
3234dc9
fix github workflows file
rarguelloF Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update contribIntegrations
Signed-off-by: keisku <keisuke.umegaki@datadoghq.com>
  • Loading branch information
keisku committed Jan 18, 2025
commit 6d5b6f6e08481a9e9bc3a9a0b87660bef4a392b3
1 change: 1 addition & 0 deletions ddtrace/tracer/option.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ var contribIntegrations = map[string]struct {
"github.com/zenazn/goji": {"Goji", false},
"log/slog": {"log/slog", false},
"github.com/uptrace/bun": {"Bun", false},
"github.com/valkey/valkey-go": {"Valkey", false},
}

var (
Expand Down
2 changes: 1 addition & 1 deletion ddtrace/tracer/option_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ func TestAgentIntegration(t *testing.T) {
defer clearIntegrationsForTests()

cfg.loadContribIntegrations(nil)
assert.Equal(t, 56, len(cfg.integrations))
assert.Equal(t, 57, len(cfg.integrations))
for integrationName, v := range cfg.integrations {
assert.False(t, v.Instrumented, "integrationName=%s", integrationName)
}
Expand Down
Loading