Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support opensearch-go tracing #3280

Draft
wants to merge 1 commit into
base: v2-dev
Choose a base branch
from
Draft

Support opensearch-go tracing #3280

wants to merge 1 commit into from

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Mar 11, 2025

What does this PR do?

Support opensearch-project/opensearch-go by manual / orchestrion instrumentation.
Tested OpenSearch v2 only because of Release Schedule and Maintenance Policy.

  • The maintenance window of OpenSearch v1 will end April 29th, 2025.
  • OpenSearch v3 is still not GA.

Motivation

#2186

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 11, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 11, 2025

Datadog Report

Branch report: keisku/opensearch-v2
Commit report: 26d1467
Test service: dd-trace-go

❌ 33 Failed (30 Known Flaky), 4342 Passed, 65 Skipped, 3m 44.43s Total Time

❌ Failed Tests (33)

This report shows up to 5 failed tests.

  • TestAppendMiddleware - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/aws - ❄️ Known flaky - Details

    Expand for error
     Failed
     
     === RUN   TestAppendMiddleware
     --- FAIL: TestAppendMiddleware (0.02s)
    
  • TestAppendMiddlewareDynamodbGetItem - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/aws - Details

    Expand for error
     Failed
     
     === RUN   TestAppendMiddlewareDynamodbGetItem
     --- FAIL: TestAppendMiddlewareDynamodbGetItem (0.02s)
    
  • TestAppendMiddlewareDynamodbGetItem/test_mocked_dynamodb_failure_request - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/aws - Details

    Expand for error
     Failed
     
     === RUN   TestAppendMiddlewareDynamodbGetItem/test_mocked_dynamodb_failure_request
         aws_test.go:560: 
             	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/aws/aws-sdk-go-v2/aws/aws_test.go:560
             	Error:      	"[]" should have 1 item(s), but has 0
             	Test:       	TestAppendMiddlewareDynamodbGetItem/test_mocked_dynamodb_failure_request
         --- FAIL: TestAppendMiddlewareDynamodbGetItem/test_mocked_dynamodb_failure_request (0.01s)
    
  • TestAppendMiddlewareDynamodbGetItem/test_mocked_dynamodb_success_request - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/aws - Details

    Expand for error
     Failed
     
     === RUN   TestAppendMiddlewareDynamodbGetItem/test_mocked_dynamodb_success_request
         aws_test.go:554: 
             	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/aws/aws-sdk-go-v2/aws/aws_test.go:554
             	Error:      	Received unexpected error:
             	            	not found, ResolveEndpointV2
             	Test:       	TestAppendMiddlewareDynamodbGetItem/test_mocked_dynamodb_success_request
         --- FAIL: TestAppendMiddlewareDynamodbGetItem/test_mocked_dynamodb_success_request (0.01s)
    
  • TestAppendMiddlewareEventBridgePutEvents - github.com/DataDog/dd-trace-go/contrib/aws/aws-sdk-go-v2/v2/aws - ❄️ Known flaky - Details

    Expand for error
     Failed
     
     === RUN   TestAppendMiddlewareEventBridgePutEvents
         aws_test.go:766: 
             	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/aws/aws-sdk-go-v2/aws/aws_test.go:766
             	Error:      	"[]" should have 1 item(s), but has 0
             	Test:       	TestAppendMiddlewareEventBridgePutEvents
     --- FAIL: TestAppendMiddlewareEventBridgePutEvents (0.01s)
    

@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2025

Benchmarks

Benchmark execution time: 2025-03-14 02:27:35

Comparing candidate commit 7bdc027 in PR branch keisku/opensearch-v2 with baseline commit fa17f59 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 2 unstable metrics.

@keisku keisku force-pushed the keisku/opensearch-v2 branch 5 times, most recently from 8f19c6a to 3a7e624 Compare March 14, 2025 01:57
Signed-off-by: keisku <keisuke.umegaki@datadoghq.com>
@keisku keisku force-pushed the keisku/opensearch-v2 branch from 3a7e624 to 7bdc027 Compare March 14, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant