ddtrace/tracer: more accurate retry logging #3327
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the writer fails to send a payload to the agent, it logs an error message that includes the text "will retry", but technically this is only true if the tracer was started with the `WithSendRetries` option (otherwise, the config value is 0 and no retries will be attempted). Would it be more accurate/less confusing to do something like this where the writer just logs "attempt N of M"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the log messages emitted on failure to send a payload to the agent to just log the current attempt count and total number of attempts that will be made, rather than always including the phrase "will retry".
Motivation
It's a small thing, but the current message can be misleading; if the tracer was not started with a non-zero
WithSendRetriesoption, or if the loop is on the last retry, "will retry" is inaccurate. There might be a nicer change to make to the message but this was the simplest thing I could think of.Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!