Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) internal/civisibility/native: test optimization native exports and api #3331

Closed
wants to merge 2 commits into from

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Mar 22, 2025

What does this PR do?

This PR introduces the exports required for a libtestoptimization native library based on Go and the build scripts for different platforms.

The repository: https://github.com/datadog/test-optimization-native uses these export to create the native library

Note: Everything is behind the civisibility_native build tag, so it doesn't effect the normal tracer build.

V1: (feat) internal/civisibility/native: test optimization native exports and api V2

Motivation

We have customers asking for native api to use it in a rust sdk and a swift for windows sdk.

I created a preview version of rust sdk crate: https://crates.io/crates/test-optimization-sdk
The sdk is being used by: https://github.com/DataDog/dd-rust-testrunner

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo force-pushed the tony/civisibility-native-api branch from 22e5a9b to 9f534f3 Compare March 22, 2025 11:38
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 22, 2025

Datadog Report

Branch report: tony/civisibility-native-api
Commit report: 6aaa8fd
Test service: dd-trace-go

✅ 0 Failed, 5475 Passed, 72 Skipped, 10m 22.12s Total Time

@tonyredondo tonyredondo marked this pull request as ready for review March 22, 2025 12:00
@tonyredondo tonyredondo requested review from a team as code owners March 22, 2025 12:00
@tonyredondo tonyredondo requested a review from Mariovido March 22, 2025 12:00
@pr-commenter
Copy link

pr-commenter bot commented Mar 22, 2025

Benchmarks

Benchmark execution time: 2025-03-22 12:04:25

Comparing candidate commit 9f534f3 in PR branch tony/civisibility-native-api with baseline commit a95495a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 2 unstable metrics.

@tonyredondo
Copy link
Member Author

it will be implemented in https://github.com/DataDog/test-optimization-native

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants