-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] run go generate and add ci check #3340
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 68 Passed, 0 Skipped, 3m 0.6s Total Time |
BenchmarksBenchmark execution time: 2025-03-26 14:16:44 Comparing candidate commit ff3c1af in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics. |
The regenerated `ddtrace/tracer/span_msgp.go` avoid writing a section for span links if not present.
What does this PR do?
go generate ./...
SpanLink
struct in theddtrace
package.make_responsewriter.go
file and fix the used one.tools/fixmodules
which ensures all modules in the repo arego mod tidy
'ed and have all the correct replace for local imports. Also add a CI check running the tool and checking it does not generate changes.Motivation
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!