Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] run go generate and add ci check #3340

Merged
merged 9 commits into from
Mar 27, 2025
Merged

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Mar 24, 2025

What does this PR do?

  • Run go generate ./...
  • Remove duplicated SpanLink struct in the ddtrace package.
  • Check generated files are up to date in CI.
  • Remove duplicated make_responsewriter.go file and fix the used one.
  • Run tools/fixmodules which ensures all modules in the repo are go mod tidy'ed and have all the correct replace for local imports. Also add a CI check running the tool and checking it does not generate changes.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@rarguelloF rarguelloF changed the base branch from main to v2-dev March 24, 2025 17:33
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 24, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 24, 2025

Datadog Report

Branch report: rarguelloF/gen-span-msgp
Commit report: 8ffc238
Test service: dd-trace-go

✅ 0 Failed, 68 Passed, 0 Skipped, 3m 0.6s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 24, 2025

Benchmarks

Benchmark execution time: 2025-03-26 14:16:44

Comparing candidate commit ff3c1af in PR branch rarguelloF/gen-span-msgp with baseline commit 57473e2 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 1 unstable metrics.

@rarguelloF rarguelloF changed the title [v2] run go generate ./... [v2] run go generate and add ci check Mar 26, 2025
@rarguelloF rarguelloF marked this pull request as ready for review March 26, 2025 13:48
@rarguelloF rarguelloF requested review from a team as code owners March 26, 2025 13:48
@darccio darccio merged commit 37fa601 into v2-dev Mar 27, 2025
193 checks passed
@darccio darccio deleted the rarguelloF/gen-span-msgp branch March 27, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants