Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: broaden go.mod/go.sum statement to **/go.mod, **/go.sum, go.work and go.work.sum files #3351

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

eliottness
Copy link
Contributor

What does this PR do?

This PR puts all go.mod related files under the same banner to cope with v2 large number of modules ans changes related to this that will happen on each small dependency upgrade to the main module.

Motivation

Guild meeing decision: Currently any dependency upgrade of the main module require a whole lot of approval with should not be feasble in the long run:
image

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

…go.work and go.work.sum files

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness marked this pull request as ready for review March 26, 2025 15:34
@eliottness eliottness requested review from a team as code owners March 26, 2025 15:34
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 26, 2025

Datadog Report

Branch report: eliottness/go.mod-codeowner
Commit report: 80f5f89
Test service: dd-trace-go

✅ 0 Failed, 4479 Passed, 66 Skipped, 23m 50.46s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 26, 2025

Benchmarks

Benchmark execution time: 2025-03-26 15:58:09

Comparing candidate commit ce40b8f in PR branch eliottness/go.mod-codeowner with baseline commit 00da388 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 0 unstable metrics.

@eliottness eliottness merged commit 7488a19 into v2-dev Mar 27, 2025
175 checks passed
@eliottness eliottness deleted the eliottness/go.mod-codeowner branch March 27, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants