Add JSON component #7973

PerfectSlayer · 2024-11-19T10:43:58Z

What Does This Do

This PR introduces a platform module to craft JSON payload.
It provides a minimalist writer to craft JSON objects and arrays, and mapper to convert simple Java object.

Motivation

The goals is to provide common capability to create simple JSON payload without relying on a JSON library that can conflict with the instrumented application.
As more and more products and features relies on JSON, gathering this capability into a dedicated reusable platform component allows to simplify the code base and consolidate the feature (in term of capability and testing) in one place.

Additional Notes

This PR is split to easily review the impact on each features relying on JSON that were migrated to this new component. It will be squashed on merge.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

github-actions · 2024-11-19T10:44:10Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2024-11-19T11:21:22Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/json-component
git_commit_date	1732203227	1732206482
git_commit_sha	`603ef41`	`ab3a7c0`
release_version	1.43.0-SNAPSHOT~603ef416b6	1.43.0-SNAPSHOT~ab3a7c0181

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732208873	1732208873
ci_job_id	715759021	715759021
ci_pipeline_id	49631781	49631781
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~ab3a7c0181, baseline=1.43.0-SNAPSHOT~603ef416b6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087183
Total [baseline] (8.63 s) : 0, 8630205
Agent [candidate] (1.105 s) : 0, 1104755
Total [candidate] (8.702 s) : 0, 8702442
section iast
Agent [baseline] (1.224 s) : 0, 1224479
Total [baseline] (9.202 s) : 0, 9201627
Agent [candidate] (1.216 s) : 0, 1216491
Total [candidate] (9.199 s) : 0, 9199318
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.217 s) : 0, 1216949
Total [baseline] (9.156 s) : 0, 9156236
Agent [candidate] (1.227 s) : 0, 1227278
Total [candidate] (9.212 s) : 0, 9212244
section iast_TELEMETRY_OFF
Agent [baseline] (1.221 s) : 0, 1220929
Total [baseline] (9.185 s) : 0, 9185498
Agent [candidate] (1.226 s) : 0, 1226418
Total [candidate] (9.22 s) : 0, 9220026

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.087 s	-
Agent	iast	1.224 s	137.296 ms (12.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.217 s	129.765 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.221 s	133.746 ms (12.3%)
Total	tracing	8.63 s	-
Total	iast	9.202 s	571.422 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.156 s	526.031 ms (6.1%)
Total	iast_TELEMETRY_OFF	9.185 s	555.293 ms (6.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.105 s	-
Agent	iast	1.216 s	111.735 ms (10.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.227 s	122.522 ms (11.1%)
Agent	iast_TELEMETRY_OFF	1.226 s	121.663 ms (11.0%)
Total	tracing	8.702 s	-
Total	iast	9.199 s	496.876 ms (5.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.212 s	509.802 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.22 s	517.584 ms (5.9%)

gantt
    title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~ab3a7c0181, baseline=1.43.0-SNAPSHOT~603ef416b6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.748 ms) : 0, 692748
BytebuddyAgent [candidate] (705.078 ms) : 0, 705078
GlobalTracer [baseline] (316.758 ms) : 0, 316758
GlobalTracer [candidate] (320.149 ms) : 0, 320149
AppSec [baseline] (54.654 ms) : 0, 54654
AppSec [candidate] (55.405 ms) : 0, 55405
Remote Config [baseline] (681.84 µs) : 0, 682
Remote Config [candidate] (704.687 µs) : 0, 705
Telemetry [baseline] (8.568 ms) : 0, 8568
Telemetry [candidate] (9.386 ms) : 0, 9386
section iast
BytebuddyAgent [baseline] (815.519 ms) : 0, 815519
BytebuddyAgent [candidate] (809.316 ms) : 0, 809316
GlobalTracer [baseline] (307.739 ms) : 0, 307739
GlobalTracer [candidate] (306.68 ms) : 0, 306680
AppSec [baseline] (55.846 ms) : 0, 55846
AppSec [candidate] (56.362 ms) : 0, 56362
Remote Config [baseline] (624.322 µs) : 0, 624
Remote Config [candidate] (615.785 µs) : 0, 616
Telemetry [baseline] (7.458 ms) : 0, 7458
Telemetry [candidate] (7.413 ms) : 0, 7413
IAST [baseline] (23.435 ms) : 0, 23435
IAST [candidate] (22.353 ms) : 0, 22353
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.199 ms) : 0, 809199
BytebuddyAgent [candidate] (815.737 ms) : 0, 815737
GlobalTracer [baseline] (307.032 ms) : 0, 307032
GlobalTracer [candidate] (309.927 ms) : 0, 309927
AppSec [baseline] (58.036 ms) : 0, 58036
AppSec [candidate] (57.589 ms) : 0, 57589
Remote Config [baseline] (622.963 µs) : 0, 623
Remote Config [candidate] (633.25 µs) : 0, 633
Telemetry [baseline] (7.514 ms) : 0, 7514
Telemetry [candidate] (7.518 ms) : 0, 7518
IAST [baseline] (20.8 ms) : 0, 20800
IAST [candidate] (21.976 ms) : 0, 21976
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (811.736 ms) : 0, 811736
BytebuddyAgent [candidate] (816.934 ms) : 0, 816934
GlobalTracer [baseline] (307.546 ms) : 0, 307546
GlobalTracer [candidate] (308.163 ms) : 0, 308163
AppSec [baseline] (56.389 ms) : 0, 56389
AppSec [candidate] (58.754 ms) : 0, 58754
Remote Config [baseline] (629.376 µs) : 0, 629
Remote Config [candidate] (629.725 µs) : 0, 630
Telemetry [baseline] (7.511 ms) : 0, 7511
Telemetry [candidate] (7.491 ms) : 0, 7491
IAST [baseline] (23.315 ms) : 0, 23315
IAST [candidate] (20.538 ms) : 0, 20538

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~ab3a7c0181, baseline=1.43.0-SNAPSHOT~603ef416b6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1097552
Total [baseline] (10.47 s) : 0, 10469694
Agent [candidate] (1.085 s) : 0, 1085267
Total [candidate] (10.462 s) : 0, 10461976
section appsec
Agent [baseline] (1.222 s) : 0, 1221659
Total [baseline] (10.724 s) : 0, 10723957
Agent [candidate] (1.225 s) : 0, 1224557
Total [candidate] (10.709 s) : 0, 10709007
section iast
Agent [baseline] (1.217 s) : 0, 1217405
Total [baseline] (10.977 s) : 0, 10976999
Agent [candidate] (1.217 s) : 0, 1216586
Total [candidate] (10.945 s) : 0, 10945436
section profiling
Agent [baseline] (1.288 s) : 0, 1287995
Total [baseline] (10.84 s) : 0, 10840116
Agent [candidate] (1.285 s) : 0, 1284547
Total [candidate] (10.777 s) : 0, 10777078

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.098 s	-
Agent	appsec	1.222 s	124.108 ms (11.3%)
Agent	iast	1.217 s	119.853 ms (10.9%)
Agent	profiling	1.288 s	190.444 ms (17.4%)
Total	tracing	10.47 s	-
Total	appsec	10.724 s	254.263 ms (2.4%)
Total	iast	10.977 s	507.305 ms (4.8%)
Total	profiling	10.84 s	370.422 ms (3.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.085 s	-
Agent	appsec	1.225 s	139.29 ms (12.8%)
Agent	iast	1.217 s	131.319 ms (12.1%)
Agent	profiling	1.285 s	199.28 ms (18.4%)
Total	tracing	10.462 s	-
Total	appsec	10.709 s	247.031 ms (2.4%)
Total	iast	10.945 s	483.46 ms (4.6%)
Total	profiling	10.777 s	315.102 ms (3.0%)

gantt
    title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~ab3a7c0181, baseline=1.43.0-SNAPSHOT~603ef416b6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.513 ms) : 0, 697513
BytebuddyAgent [candidate] (691.085 ms) : 0, 691085
GlobalTracer [baseline] (320.958 ms) : 0, 320958
GlobalTracer [candidate] (316.662 ms) : 0, 316662
AppSec [baseline] (55.194 ms) : 0, 55194
AppSec [candidate] (54.565 ms) : 0, 54565
Remote Config [baseline] (688.829 µs) : 0, 689
Remote Config [candidate] (681.527 µs) : 0, 682
Telemetry [baseline] (9.386 ms) : 0, 9386
Telemetry [candidate] (8.572 ms) : 0, 8572
section appsec
BytebuddyAgent [baseline] (708.462 ms) : 0, 708462
BytebuddyAgent [candidate] (709.848 ms) : 0, 709848
GlobalTracer [baseline] (313.533 ms) : 0, 313533
GlobalTracer [candidate] (315.185 ms) : 0, 315185
AppSec [baseline] (166.475 ms) : 0, 166475
AppSec [candidate] (165.856 ms) : 0, 165856
Remote Config [baseline] (641.502 µs) : 0, 642
Remote Config [candidate] (656.284 µs) : 0, 656
Telemetry [baseline] (8.944 ms) : 0, 8944
Telemetry [candidate] (8.936 ms) : 0, 8936
IAST [baseline] (19.809 ms) : 0, 19809
IAST [candidate] (20.623 ms) : 0, 20623
section iast
BytebuddyAgent [baseline] (810.481 ms) : 0, 810481
BytebuddyAgent [candidate] (809.704 ms) : 0, 809704
GlobalTracer [baseline] (306.633 ms) : 0, 306633
GlobalTracer [candidate] (306.306 ms) : 0, 306306
AppSec [baseline] (57.045 ms) : 0, 57045
AppSec [candidate] (56.36 ms) : 0, 56360
Remote Config [baseline] (616.577 µs) : 0, 617
Remote Config [candidate] (614.233 µs) : 0, 614
Telemetry [baseline] (7.361 ms) : 0, 7361
Telemetry [candidate] (7.426 ms) : 0, 7426
IAST [baseline] (21.564 ms) : 0, 21564
IAST [candidate] (22.437 ms) : 0, 22437
section profiling
BytebuddyAgent [baseline] (687.27 ms) : 0, 687270
BytebuddyAgent [candidate] (685.096 ms) : 0, 685096
GlobalTracer [baseline] (400.948 ms) : 0, 400948
GlobalTracer [candidate] (399.954 ms) : 0, 399954
AppSec [baseline] (55.245 ms) : 0, 55245
AppSec [candidate] (55.067 ms) : 0, 55067
Remote Config [baseline] (675.475 µs) : 0, 675
Remote Config [candidate] (672.243 µs) : 0, 672
Telemetry [baseline] (11.441 ms) : 0, 11441
Telemetry [candidate] (12.769 ms) : 0, 12769
ProfilingAgent [baseline] (93.433 ms) : 0, 93433
ProfilingAgent [candidate] (91.966 ms) : 0, 91966
Profiling [baseline] (93.457 ms) : 0, 93457
Profiling [candidate] (91.989 ms) : 0, 91989

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-21T16:38:05	2024-11-21T16:45:03
git_branch	master	bbujon/json-component
git_commit_date	1732203227	1732206482
git_commit_sha	`603ef41`	`ab3a7c0`
release_version	1.43.0-SNAPSHOT~603ef416b6	1.43.0-SNAPSHOT~ab3a7c0181
start_time	2024-11-21T16:37:52	2024-11-21T16:44:50

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732207854	1732207854
ci_job_id	715759022	715759022
ci_pipeline_id	49631781	49631781
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ab3a7c0181, baseline=1.43.0-SNAPSHOT~603ef416b6
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.749 µs) : 358, 398
.   : milestone, 378,
iast (486.229 µs) : 465, 508
.   : milestone, 486,
iast_FULL (646.58 µs) : 625, 668
.   : milestone, 647,
iast_GLOBAL (515.836 µs) : 494, 538
.   : milestone, 516,
iast_HARDCODED_SECRET_DISABLED (486.296 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (445.373 µs) : 425, 466
.   : milestone, 445,
iast_TELEMETRY_OFF (474.033 µs) : 453, 495
.   : milestone, 474,
tracing (444.834 µs) : 424, 465
.   : milestone, 445,
section candidate
no_agent (373.272 µs) : 354, 393
.   : milestone, 373,
iast (485.01 µs) : 464, 506
.   : milestone, 485,
iast_FULL (647.442 µs) : 626, 669
.   : milestone, 647,
iast_GLOBAL (525.456 µs) : 503, 548
.   : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (490.694 µs) : 469, 513
.   : milestone, 491,
iast_INACTIVE (443.909 µs) : 423, 465
.   : milestone, 444,
iast_TELEMETRY_OFF (475.055 µs) : 454, 497
.   : milestone, 475,
tracing (449.011 µs) : 428, 470
.   : milestone, 449,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.749 µs [357.811 µs, 397.688 µs]	-
iast	486.229 µs [464.751 µs, 507.706 µs]	108.479 µs (28.7%)
iast_FULL	646.58 µs [625.042 µs, 668.119 µs]	268.831 µs (71.2%)
iast_GLOBAL	515.836 µs [494.162 µs, 537.51 µs]	138.086 µs (36.6%)
iast_HARDCODED_SECRET_DISABLED	486.296 µs [465.218 µs, 507.375 µs]	108.547 µs (28.7%)
iast_INACTIVE	445.373 µs [424.825 µs, 465.921 µs]	67.623 µs (17.9%)
iast_TELEMETRY_OFF	474.033 µs [452.716 µs, 495.35 µs]	96.284 µs (25.5%)
tracing	444.834 µs [424.368 µs, 465.3 µs]	67.085 µs (17.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.272 µs [353.743 µs, 392.8 µs]	-
iast	485.01 µs [463.674 µs, 506.347 µs]	111.739 µs (29.9%)
iast_FULL	647.442 µs [626.084 µs, 668.801 µs]	274.171 µs (73.5%)
iast_GLOBAL	525.456 µs [502.851 µs, 548.061 µs]	152.184 µs (40.8%)
iast_HARDCODED_SECRET_DISABLED	490.694 µs [468.525 µs, 512.864 µs]	117.423 µs (31.5%)
iast_INACTIVE	443.909 µs [423.185 µs, 464.632 µs]	70.637 µs (18.9%)
iast_TELEMETRY_OFF	475.055 µs [453.6 µs, 496.509 µs]	101.783 µs (27.3%)
tracing	449.011 µs [427.541 µs, 470.481 µs]	75.739 µs (20.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~ab3a7c0181, baseline=1.43.0-SNAPSHOT~603ef416b6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1322, 1363
.   : milestone, 1342,
appsec (1.756 ms) : 1732, 1781
.   : milestone, 1756,
appsec_no_iast (1.747 ms) : 1722, 1772
.   : milestone, 1747,
iast (1.511 ms) : 1489, 1533
.   : milestone, 1511,
profiling (1.556 ms) : 1531, 1581
.   : milestone, 1556,
tracing (1.504 ms) : 1480, 1529
.   : milestone, 1504,
section candidate
no_agent (1.344 ms) : 1324, 1364
.   : milestone, 1344,
appsec (1.738 ms) : 1713, 1763
.   : milestone, 1738,
appsec_no_iast (1.728 ms) : 1703, 1754
.   : milestone, 1728,
iast (1.499 ms) : 1476, 1521
.   : milestone, 1499,
profiling (1.512 ms) : 1489, 1535
.   : milestone, 1512,
tracing (1.492 ms) : 1469, 1516
.   : milestone, 1492,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.342 ms [1.322 ms, 1.363 ms]	-
appsec	1.756 ms [1.732 ms, 1.781 ms]	414.123 µs (30.9%)
appsec_no_iast	1.747 ms [1.722 ms, 1.772 ms]	404.667 µs (30.1%)
iast	1.511 ms [1.489 ms, 1.533 ms]	169.023 µs (12.6%)
profiling	1.556 ms [1.531 ms, 1.581 ms]	213.545 µs (15.9%)
tracing	1.504 ms [1.48 ms, 1.529 ms]	161.782 µs (12.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.344 ms [1.324 ms, 1.364 ms]	-
appsec	1.738 ms [1.713 ms, 1.763 ms]	393.726 µs (29.3%)
appsec_no_iast	1.728 ms [1.703 ms, 1.754 ms]	383.958 µs (28.6%)
iast	1.499 ms [1.476 ms, 1.521 ms]	154.509 µs (11.5%)
profiling	1.512 ms [1.489 ms, 1.535 ms]	167.583 µs (12.5%)
tracing	1.492 ms [1.469 ms, 1.516 ms]	148.16 µs (11.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bbujon/json-component
git_commit_date	1732203227	1732206482
git_commit_sha	`603ef41`	`ab3a7c0`
release_version	1.43.0-SNAPSHOT~603ef416b6	1.43.0-SNAPSHOT~ab3a7c0181

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732208405	1732208405
ci_job_id	715759025	715759025
ci_pipeline_id	49631781	49631781
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ab3a7c0181, baseline=1.43.0-SNAPSHOT~603ef416b6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.357 s) : 15357000, 15357000
.   : milestone, 15357000,
appsec (15.068 s) : 15068000, 15068000
.   : milestone, 15068000,
iast (18.826 s) : 18826000, 18826000
.   : milestone, 18826000,
iast_GLOBAL (18.3 s) : 18300000, 18300000
.   : milestone, 18300000,
profiling (14.779 s) : 14779000, 14779000
.   : milestone, 14779000,
tracing (14.869 s) : 14869000, 14869000
.   : milestone, 14869000,
section candidate
no_agent (15.186 s) : 15186000, 15186000
.   : milestone, 15186000,
appsec (14.943 s) : 14943000, 14943000
.   : milestone, 14943000,
iast (18.532 s) : 18532000, 18532000
.   : milestone, 18532000,
iast_GLOBAL (18.048 s) : 18048000, 18048000
.   : milestone, 18048000,
profiling (15.324 s) : 15324000, 15324000
.   : milestone, 15324000,
tracing (15.093 s) : 15093000, 15093000
.   : milestone, 15093000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.357 s [15.357 s, 15.357 s]	-
appsec	15.068 s [15.068 s, 15.068 s]	-289.0 ms (-1.9%)
iast	18.826 s [18.826 s, 18.826 s]	3.469 s (22.6%)
iast_GLOBAL	18.3 s [18.3 s, 18.3 s]	2.943 s (19.2%)
profiling	14.779 s [14.779 s, 14.779 s]	-578.0 ms (-3.8%)
tracing	14.869 s [14.869 s, 14.869 s]	-488.0 ms (-3.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.186 s [15.186 s, 15.186 s]	-
appsec	14.943 s [14.943 s, 14.943 s]	-243.0 ms (-1.6%)
iast	18.532 s [18.532 s, 18.532 s]	3.346 s (22.0%)
iast_GLOBAL	18.048 s [18.048 s, 18.048 s]	2.862 s (18.8%)
profiling	15.324 s [15.324 s, 15.324 s]	138.0 ms (0.9%)
tracing	15.093 s [15.093 s, 15.093 s]	-93.0 ms (-0.6%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~ab3a7c0181, baseline=1.43.0-SNAPSHOT~603ef416b6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.33 ms) : 2289, 2372
.   : milestone, 2330,
iast (2.068 ms) : 2016, 2120
.   : milestone, 2068,
iast_GLOBAL (2.116 ms) : 2064, 2169
.   : milestone, 2116,
profiling (1.956 ms) : 1914, 1999
.   : milestone, 1956,
tracing (1.909 ms) : 1869, 1948
.   : milestone, 1909,
section candidate
no_agent (1.462 ms) : 1451, 1474
.   : milestone, 1462,
appsec (2.314 ms) : 2274, 2355
.   : milestone, 2314,
iast (2.074 ms) : 2022, 2126
.   : milestone, 2074,
iast_GLOBAL (2.111 ms) : 2059, 2163
.   : milestone, 2111,
profiling (1.942 ms) : 1900, 1984
.   : milestone, 1942,
tracing (1.914 ms) : 1873, 1954
.   : milestone, 1914,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.463 ms [1.451 ms, 1.474 ms]	-
appsec	2.33 ms [2.289 ms, 2.372 ms]	867.569 µs (59.3%)
iast	2.068 ms [2.016 ms, 2.12 ms]	605.284 µs (41.4%)
iast_GLOBAL	2.116 ms [2.064 ms, 2.169 ms]	653.624 µs (44.7%)
profiling	1.956 ms [1.914 ms, 1.999 ms]	493.571 µs (33.7%)
tracing	1.909 ms [1.869 ms, 1.948 ms]	445.767 µs (30.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.462 ms [1.451 ms, 1.474 ms]	-
appsec	2.314 ms [2.274 ms, 2.355 ms]	852.118 µs (58.3%)
iast	2.074 ms [2.022 ms, 2.126 ms]	611.453 µs (41.8%)
iast_GLOBAL	2.111 ms [2.059 ms, 2.163 ms]	648.704 µs (44.4%)
profiling	1.942 ms [1.9 ms, 1.984 ms]	479.612 µs (32.8%)
tracing	1.914 ms [1.873 ms, 1.954 ms]	451.225 µs (30.9%)

components/json/json-io/src/main/java/datadog/json/io/JsonWriter.java

PerfectSlayer requested review from a team as code owners November 19, 2024 10:43

PerfectSlayer requested review from tonyredondo and nayeem-kamal November 19, 2024 10:43

PerfectSlayer marked this pull request as draft November 19, 2024 10:44

PerfectSlayer force-pushed the bbujon/json-component branch 2 times, most recently from 9eff3df to 0a2b5c0 Compare November 20, 2024 09:01

datadog-datadog-prod-us1 bot reviewed Nov 20, 2024

View reviewed changes

components/json/json-io/src/main/java/datadog/json/io/JsonWriter.java Outdated Show resolved Hide resolved

PerfectSlayer mentioned this pull request Nov 21, 2024

Inject trace context into AWS Step Functions input #7585

Open

5 tasks

PerfectSlayer force-pushed the bbujon/json-component branch from b6f3e76 to 546b7c8 Compare November 21, 2024 16:16

PerfectSlayer added 8 commits November 21, 2024 17:27

feat(json): Add JSON component

828bc58

feat(internal-api): Remove Strings toJson and escapeToJson methods

6c55f8c

feat(ci-visibility): Migrate to JSON component

5331013

feat(junit-4.10): Migrate to JSON component

6ad7a9a

feat(junit-5.3): Migrate to JSON component

a519479

feat(karate): Migrate to JSON component

d3c3778

feat(testng): Migrate to JSON component

8e04c2b

feat(bootstrap): Migrate to JSON component

ab3a7c0

PerfectSlayer force-pushed the bbujon/json-component branch from 546b7c8 to ab3a7c0 Compare November 21, 2024 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JSON component #7973

Add JSON component #7973

PerfectSlayer commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 19, 2024

pr-commenter bot commented Nov 19, 2024 •

edited

Loading

Add JSON component #7973

Are you sure you want to change the base?

Add JSON component #7973

Conversation

PerfectSlayer commented Nov 19, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

github-actions bot commented Nov 19, 2024

pr-commenter bot commented Nov 19, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Add JSON component #7973

Add JSON component #7973

PerfectSlayer commented Nov 19, 2024 •

edited

Loading

pr-commenter bot commented Nov 19, 2024 •

edited

Loading