-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JMXFetch to TracerInstaller for GraalVM Native #8569
Draft
ygree
wants to merge
1
commit into
master
Choose a base branch
from
ygree/graal-native-jmxfetch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error: Discovered unresolved method during parsing: org.datadog.jmxfetch.App.<init>(org.datadog.jmxfetch.AppConfig).
BenchmarksStartupParameters
See matching parameters
SummaryFound 5 performance improvements and 14 performance regressions! Performance is the same for 36 metrics, 8 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~634df59c56, baseline=1.48.0-SNAPSHOT~c06a40868a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067797
Total [baseline] (10.662 s) : 0, 10661593
Agent [candidate] (1.1 s) : 0, 1100034
Total [candidate] (10.724 s) : 0, 10723861
section appsec
Agent [baseline] (1.211 s) : 0, 1210612
Total [baseline] (10.967 s) : 0, 10966828
Agent [candidate] (1.223 s) : 0, 1223375
Total [candidate] (10.99 s) : 0, 10989894
section iast
Agent [baseline] (1.202 s) : 0, 1202227
Total [baseline] (11.292 s) : 0, 11291697
Agent [candidate] (1.226 s) : 0, 1226041
Total [candidate] (11.166 s) : 0, 11166093
section profiling
Agent [baseline] (1.296 s) : 0, 1296089
Total [baseline] (11.184 s) : 0, 11184173
Agent [candidate] (1.336 s) : 0, 1335699
Total [candidate] (11.215 s) : 0, 11214776
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~634df59c56, baseline=1.48.0-SNAPSHOT~c06a40868a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (733.527 ms) : 0, 733527
BytebuddyAgent [candidate] (734.378 ms) : 0, 734378
GlobalTracer [baseline] (246.299 ms) : 0, 246299
GlobalTracer [candidate] (275.365 ms) : 0, 275365
AppSec [baseline] (55.871 ms) : 0, 55871
AppSec [candidate] (58.91 ms) : 0, 58910
Remote Config [baseline] (715.597 µs) : 0, 716
Remote Config [candidate] (1.583 ms) : 0, 1583
Telemetry [baseline] (15.96 ms) : 0, 15960
Telemetry [candidate] (14.621 ms) : 0, 14621
section appsec
BytebuddyAgent [baseline] (751.123 ms) : 0, 751123
BytebuddyAgent [candidate] (750.759 ms) : 0, 750759
GlobalTracer [baseline] (243.176 ms) : 0, 243176
GlobalTracer [candidate] (271.454 ms) : 0, 271454
IAST [baseline] (22.056 ms) : 0, 22056
IAST [candidate] (22.556 ms) : 0, 22556
AppSec [baseline] (180.649 ms) : 0, 180649
AppSec [candidate] (164.62 ms) : 0, 164620
Remote Config [baseline] (679.944 µs) : 0, 680
Remote Config [candidate] (712.638 µs) : 0, 713
Telemetry [baseline] (8.494 ms) : 0, 8494
Telemetry [candidate] (9.416 ms) : 0, 9416
section iast
BytebuddyAgent [baseline] (858.932 ms) : 0, 858932
BytebuddyAgent [candidate] (854.012 ms) : 0, 854012
GlobalTracer [baseline] (237.472 ms) : 0, 237472
GlobalTracer [candidate] (264.82 ms) : 0, 264820
IAST [baseline] (23.713 ms) : 0, 23713
IAST [candidate] (32.42 ms) : 0, 32420
AppSec [baseline] (57.081 ms) : 0, 57081
AppSec [candidate] (49.95 ms) : 0, 49950
Remote Config [baseline] (633.4 µs) : 0, 633
Remote Config [candidate] (639.382 µs) : 0, 639
Telemetry [baseline] (8.925 ms) : 0, 8925
Telemetry [candidate] (9.0 ms) : 0, 9000
section profiling
BytebuddyAgent [baseline] (722.801 ms) : 0, 722801
BytebuddyAgent [candidate] (730.777 ms) : 0, 730777
GlobalTracer [baseline] (369.072 ms) : 0, 369072
GlobalTracer [candidate] (396.278 ms) : 0, 396278
AppSec [baseline] (55.57 ms) : 0, 55570
AppSec [candidate] (55.383 ms) : 0, 55383
Remote Config [baseline] (707.436 µs) : 0, 707
Remote Config [candidate] (701.375 µs) : 0, 701
Telemetry [baseline] (9.279 ms) : 0, 9279
Telemetry [candidate] (9.215 ms) : 0, 9215
ProfilingAgent [baseline] (97.161 ms) : 0, 97161
ProfilingAgent [candidate] (102.022 ms) : 0, 102022
Profiling [baseline] (97.187 ms) : 0, 97187
Profiling [candidate] (102.082 ms) : 0, 102082
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~634df59c56, baseline=1.48.0-SNAPSHOT~c06a40868a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068739
Total [baseline] (9.256 s) : 0, 9256344
Agent [candidate] (1.091 s) : 0, 1090839
Total [candidate] (9.192 s) : 0, 9192105
section iast
Agent [baseline] (1.198 s) : 0, 1198309
Total [baseline] (9.824 s) : 0, 9824415
Agent [candidate] (1.222 s) : 0, 1222496
Total [candidate] (9.819 s) : 0, 9818611
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1204351
Total [baseline] (9.847 s) : 0, 9846975
Agent [candidate] (1.223 s) : 0, 1223282
Total [candidate] (9.779 s) : 0, 9778847
section iast_TELEMETRY_OFF
Agent [baseline] (1.194 s) : 0, 1194403
Total [baseline] (9.795 s) : 0, 9794634
Agent [candidate] (1.226 s) : 0, 1225809
Total [candidate] (9.901 s) : 0, 9900994
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~634df59c56, baseline=1.48.0-SNAPSHOT~c06a40868a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (735.094 ms) : 0, 735094
BytebuddyAgent [candidate] (729.55 ms) : 0, 729550
GlobalTracer [baseline] (248.171 ms) : 0, 248171
GlobalTracer [candidate] (271.808 ms) : 0, 271808
AppSec [baseline] (56.42 ms) : 0, 56420
AppSec [candidate] (60.243 ms) : 0, 60243
Remote Config [baseline] (728.579 µs) : 0, 729
Remote Config [candidate] (722.413 µs) : 0, 722
Telemetry [baseline] (12.886 ms) : 0, 12886
Telemetry [candidate] (13.42 ms) : 0, 13420
section iast
BytebuddyAgent [baseline] (853.543 ms) : 0, 853543
BytebuddyAgent [candidate] (851.629 ms) : 0, 851629
GlobalTracer [baseline] (238.11 ms) : 0, 238110
GlobalTracer [candidate] (264.125 ms) : 0, 264125
IAST [baseline] (23.741 ms) : 0, 23741
IAST [candidate] (31.211 ms) : 0, 31211
AppSec [baseline] (57.849 ms) : 0, 57849
AppSec [candidate] (50.716 ms) : 0, 50716
Remote Config [baseline] (627.527 µs) : 0, 628
Remote Config [candidate] (638.453 µs) : 0, 638
Telemetry [baseline] (8.979 ms) : 0, 8979
Telemetry [candidate] (9.019 ms) : 0, 9019
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (858.019 ms) : 0, 858019
BytebuddyAgent [candidate] (852.139 ms) : 0, 852139
GlobalTracer [baseline] (239.477 ms) : 0, 239477
GlobalTracer [candidate] (265.13 ms) : 0, 265130
IAST [baseline] (23.563 ms) : 0, 23563
IAST [candidate] (30.391 ms) : 0, 30391
AppSec [baseline] (58.065 ms) : 0, 58065
AppSec [candidate] (50.743 ms) : 0, 50743
Remote Config [baseline] (630.639 µs) : 0, 631
Remote Config [candidate] (645.332 µs) : 0, 645
Telemetry [baseline] (9.073 ms) : 0, 9073
Telemetry [candidate] (9.031 ms) : 0, 9031
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (850.051 ms) : 0, 850051
BytebuddyAgent [candidate] (854.654 ms) : 0, 854654
GlobalTracer [baseline] (238.226 ms) : 0, 238226
GlobalTracer [candidate] (270.785 ms) : 0, 270785
IAST [baseline] (23.346 ms) : 0, 23346
IAST [candidate] (25.408 ms) : 0, 25408
AppSec [baseline] (57.804 ms) : 0, 57804
AppSec [candidate] (50.027 ms) : 0, 50027
Remote Config [baseline] (635.548 µs) : 0, 636
Remote Config [candidate] (662.758 µs) : 0, 663
Telemetry [baseline] (8.913 ms) : 0, 8913
Telemetry [candidate] (9.023 ms) : 0, 9023
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~634df59c56, baseline=1.48.0-SNAPSHOT~c06a40868a
dateFormat X
axisFormat %s
section baseline
no_agent (1.371 ms) : 1352, 1391
. : milestone, 1371,
appsec (1.767 ms) : 1742, 1791
. : milestone, 1767,
appsec_no_iast (1.718 ms) : 1693, 1742
. : milestone, 1718,
code_origins (1.712 ms) : 1685, 1740
. : milestone, 1712,
iast (1.522 ms) : 1498, 1546
. : milestone, 1522,
profiling (1.541 ms) : 1518, 1564
. : milestone, 1541,
tracing (1.513 ms) : 1488, 1537
. : milestone, 1513,
section candidate
no_agent (1.356 ms) : 1336, 1376
. : milestone, 1356,
appsec (1.752 ms) : 1727, 1776
. : milestone, 1752,
appsec_no_iast (1.772 ms) : 1748, 1796
. : milestone, 1772,
code_origins (1.677 ms) : 1643, 1711
. : milestone, 1677,
iast (1.522 ms) : 1497, 1548
. : milestone, 1522,
profiling (1.545 ms) : 1522, 1567
. : milestone, 1545,
tracing (1.531 ms) : 1504, 1558
. : milestone, 1531,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~634df59c56, baseline=1.48.0-SNAPSHOT~c06a40868a
dateFormat X
axisFormat %s
section baseline
no_agent (383.854 µs) : 364, 404
. : milestone, 384,
iast (517.865 µs) : 496, 540
. : milestone, 518,
iast_FULL (735.047 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (575.048 µs) : 552, 598
. : milestone, 575,
iast_HARDCODED_SECRET_DISABLED (519.709 µs) : 498, 542
. : milestone, 520,
iast_INACTIVE (468.993 µs) : 448, 490
. : milestone, 469,
iast_TELEMETRY_OFF (507.021 µs) : 485, 529
. : milestone, 507,
tracing (468.138 µs) : 447, 489
. : milestone, 468,
section candidate
no_agent (386.484 µs) : 367, 406
. : milestone, 386,
iast (518.865 µs) : 497, 541
. : milestone, 519,
iast_FULL (734.711 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (566.474 µs) : 545, 588
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (522.019 µs) : 500, 544
. : milestone, 522,
iast_INACTIVE (475.516 µs) : 454, 497
. : milestone, 476,
iast_TELEMETRY_OFF (497.947 µs) : 476, 520
. : milestone, 498,
tracing (463.693 µs) : 442, 485
. : milestone, 464,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~634df59c56, baseline=1.48.0-SNAPSHOT~c06a40868a
dateFormat X
axisFormat %s
section baseline
no_agent (15.445 s) : 15445000, 15445000
. : milestone, 15445000,
appsec (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
iast (18.774 s) : 18774000, 18774000
. : milestone, 18774000,
iast_GLOBAL (17.922 s) : 17922000, 17922000
. : milestone, 17922000,
profiling (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
tracing (15.04 s) : 15040000, 15040000
. : milestone, 15040000,
section candidate
no_agent (15.443 s) : 15443000, 15443000
. : milestone, 15443000,
appsec (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
iast (18.849 s) : 18849000, 18849000
. : milestone, 18849000,
iast_GLOBAL (18.738 s) : 18738000, 18738000
. : milestone, 18738000,
profiling (15.225 s) : 15225000, 15225000
. : milestone, 15225000,
tracing (14.744 s) : 14744000, 14744000
. : milestone, 14744000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~634df59c56, baseline=1.48.0-SNAPSHOT~c06a40868a
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.34 ms) : 2297, 2384
. : milestone, 2340,
iast (2.121 ms) : 2066, 2177
. : milestone, 2121,
iast_GLOBAL (2.177 ms) : 2121, 2233
. : milestone, 2177,
profiling (1.987 ms) : 1942, 2031
. : milestone, 1987,
tracing (1.963 ms) : 1920, 2005
. : milestone, 1963,
section candidate
no_agent (1.477 ms) : 1465, 1489
. : milestone, 1477,
appsec (2.365 ms) : 2322, 2408
. : milestone, 2365,
iast (2.127 ms) : 2072, 2182
. : milestone, 2127,
iast_GLOBAL (2.159 ms) : 2104, 2214
. : milestone, 2159,
profiling (1.991 ms) : 1946, 2036
. : milestone, 1991,
tracing (1.944 ms) : 1902, 1986
. : milestone, 1944,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: Discovered unresolved method during parsing: org.datadog.jmxfetch.App.(org.datadog.jmxfetch.AppConfig).
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]