-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prof) I/O profiling preview #3083
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3083 +/- ##
============================================
+ Coverage 72.95% 74.74% +1.79%
Complexity 2790 2790
============================================
Files 139 112 -27
Lines 15280 11042 -4238
Branches 1047 0 -1047
============================================
- Hits 11147 8253 -2894
+ Misses 3580 2789 -791
+ Partials 553 0 -553
Flags with carried forward coverage won't be shown. Click here to find out more. see 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Benchmarks [ profiler ]Benchmark execution time: 2025-02-14 10:52:33 Comparing candidate commit 016d5c8 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 5 unstable metrics. scenario:walk_stack/1
|
6244902
to
826265c
Compare
Description
This adds I/O profiling preview to the PHP profiler on Linux machines (it is only compiled for Linux, but technically this is a ELF64 feature and could work on other OS that are using ELF64 too):
DD_PROFILING_IO_ENABLED
/datadog.profiling.io_enabled
configuration (defaultfalse
)socket_read_time
socket_write_time
file_read_time
file_write_time
socket_read_size
socket_write_size
file_read_size
file_write_size
Known limitations:
mmap()
is not observedmmap()
support)Those things will be added/handled in future PRs, also because this feature is still experimental. The sampling distances are best guess and will likely be adjusted later.
https://datadoghq.atlassian.net/browse/PROF-11288
Reviewer checklist