fix(celery): change out.host tags to point to celery broker

[ZStriker19]

Motivation

Change out.host tags to point towards the celery broker, instead of the local celery hostname. Fixes service-representation issues.

Fixes 11491

Checklist

• PR author has checked that all the criteria below are met
• The PR description includes an overview of the change
• The PR description articulates the motivation for the change
• The change includes tests OR the PR description describes a testing strategy
• The PR description notes risks associated with the change, if any
• Newly-added code is easy to change
• The change follows the library release note guidelines
• The change includes or references documentation updates if necessary
• Backport labels are set (if applicable)

Reviewer Checklist

• Reviewer has checked that all the criteria below are met
• Title is accurate
• All changes are related to the pull request's stated goal
• Avoids breaking API changes
• Testing strategy adequately addresses listed risks
• Newly-added code is easy to change
• Release note makes sense to a user of the library
• If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
• Backport labels are set in a manner that is consistent with the release branch maintenance policy

[github-actions]

CODEOWNERS have been resolved as:

releasenotes/notes/update-celery-out-host-tag-be8da4f2ab88b4cf.yaml     @DataDog/apm-python
tests/contrib/celery/test_tagging.py                                    @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/celery/signals.py                              @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/celery/base.py                                            @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/celery/test_integration.py                                @DataDog/apm-core-python @DataDog/apm-idm-python

[datadog-dd-trace-py-rkomorn]

Datadog Report

Branch report: zachg/fix_celery_outgoing_tags
Commit report: d644a36
Test service: dd-trace-py

✅ 0 Failed, 1097 Passed, 281 Skipped, 8m 50.59s Total duration (17m 43.95s time saved)

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-11-22 22:02:14

Comparing candidate commit 3021b57 in PR branch zachg/fix_celery_outgoing_tags with baseline commit 688fa7f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

[erikayasuda]

nit: What is this comment for? Could we maybe elaborate?

[erikayasuda]

Should we just make this into a snapshot test?

[erikayasuda]

Forgot to approve, oops

[djova]

out.host should contain only the host (server.address in otel terms), so we should omit the "scheme" in this case.

[wantsui]

Since one of the assertions is assert async_span.get_tag("out.host") == "memory://", I think we should only omit it if it doesn't say memory.

Otherwise, that span tag will be completely blank in the "memory scenario".

[djova]

Since one of the assertions is assert async_span.get_tag("out.host") == "memory://", I think we should only omit it if it doesn't say memory.

OK, that works.