chore(di): trigger probes #10942

P403n1x87 · 2024-10-04T10:46:08Z

We implement trigger probes. These allows triggering the capture of debug information along a trace, ensuring all the relevant probes are also triggered.

Checklist

PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)

Reviewer Checklist

Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance policy

github-actions · 2024-10-04T10:46:41Z

CODEOWNERS have been resolved as:

ddtrace/debugging/_live.py                                              @DataDog/debugger-python
ddtrace/debugging/_products/live_debugger.py                            @DataDog/debugger-python
ddtrace/debugging/_session.py                                           @DataDog/debugger-python
ddtrace/debugging/_signal/trigger.py                                    @DataDog/debugger-python
ddtrace/settings/live_debugging.py                                      @DataDog/apm-core-python
tests/debugging/live/__init__.py                                        @DataDog/debugger-python
tests/debugging/live/test_live_debugger.py                              @DataDog/debugger-python
tests/debugging/test_session.py                                         @DataDog/debugger-python
ddtrace/_trace/context.py                                               @DataDog/apm-sdk-api-python
ddtrace/contrib/internal/trace_utils.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/debugging/_exception/replay.py                                  @DataDog/debugger-python
ddtrace/debugging/_origin/span.py                                       @DataDog/debugger-python
ddtrace/debugging/_probe/model.py                                       @DataDog/debugger-python
ddtrace/debugging/_probe/remoteconfig.py                                @DataDog/debugger-python
ddtrace/debugging/_signal/__init__.py                                   @DataDog/debugger-python
ddtrace/debugging/_signal/collector.py                                  @DataDog/debugger-python
ddtrace/debugging/_signal/model.py                                      @DataDog/debugger-python
ddtrace/debugging/_uploader.py                                          @DataDog/debugger-python
ddtrace/propagation/http.py                                             @DataDog/apm-sdk-api-python
docs/configuration.rst                                                  @DataDog/python-guild
pyproject.toml                                                          @DataDog/python-guild
tests/debugging/conftest.py                                             @DataDog/debugger-python
tests/debugging/mocking.py                                              @DataDog/debugger-python
tests/debugging/origin/test_span.py                                     @DataDog/debugger-python
tests/debugging/signal/test_collector.py                                @DataDog/debugger-python
tests/debugging/test_debugger_span_decoration.py                        @DataDog/debugger-python
tests/debugging/utils.py                                                @DataDog/debugger-python
tests/submod/traced_stuff.py                                            @DataDog/apm-core-python
tests/tracer/test_context.py                                            @DataDog/apm-sdk-api-python

pr-commenter · 2024-10-04T11:29:41Z

Benchmarks

Benchmark execution time: 2025-02-12 18:27:45

Comparing candidate commit 57efadc in PR branch chore/trigger-probe with baseline commit b4711ea in branch main.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 391 metrics, 2 unstable metrics.

scenario:httppropagationextract-all_styles_all_headers

🟩 execution_time [-5.792µs; -5.495µs] or [-8.524%; -8.087%]

scenario:iast_aspects-ospathsplit_aspect

🟥 execution_time [+341.831ns; +405.579ns] or [+8.799%; +10.440%]

scenario:iast_aspects-ospathsplitext_aspect

🟥 execution_time [+352.599ns; +405.597ns] or [+9.836%; +11.314%]

datadog-dd-trace-py-rkomorn · 2024-10-05T10:12:26Z

Datadog Report

Branch report: chore/trigger-probe
Commit report: 33e9235
Test service: dd-trace-py

✅ 0 Failed, 1598 Passed, 0 Skipped, 26m 28.34s Total duration (14m 8.72s time saved)

shatzi

very cool progress, thank you

ddtrace/contrib/trace_utils.py

ddtrace/debugging/_origin/span.py

ddtrace/debugging/_session.py

ddtrace/debugging/_live.py

ddtrace/debugging/_session.py

We implement trigger probes. These allows triggering the capture of debug information along a trace, ensuring all the relevant probes are also triggered.

shatzi

Thank you!

ddtrace/debugging/_origin/span.py

ddtrace/debugging/_probe/model.py

ddtrace/debugging/_session.py

ddtrace/debugging/_signal/model.py

ddtrace/debugging/_signal/trigger.py

ddtrace/settings/code_origin.py

tests/debugging/test_session.py

shatzi

I think the only thing that left is probe budget for probe with session

ddtrace/debugging/_origin/span.py

tests/debugging/test_session.py

shatzi

one important comment

ddtrace/debugging/_session.py

ddtrace/debugging/_probe/model.py

ddtrace/debugging/_probe/remoteconfig.py

datadog-dd-trace-py-rkomorn · 2025-01-23T12:02:27Z

Datadog Report

Branch report: chore/trigger-probe
Commit report: 57efadc
Test service: dd-trace-py

✅ 0 Failed, 869 Passed, 445 Skipped, 13m 12.48s Total duration (16m 43.84s time saved)

We implement trigger probes. These allows triggering the capture of debug information along a trace, ensuring all the relevant probes are also triggered. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Oct 4, 2024

P403n1x87 self-assigned this Oct 4, 2024

P403n1x87 force-pushed the chore/trigger-probe branch from a804567 to 766843f Compare October 5, 2024 09:59

shatzi reviewed Oct 15, 2024

View reviewed changes

P403n1x87 force-pushed the chore/trigger-probe branch 3 times, most recently from 965b6e6 to 59e7d30 Compare October 19, 2024 19:56

datadog-datadog-prod-us1 bot reviewed Oct 19, 2024

View reviewed changes

ddtrace/debugging/_session.py Outdated Show resolved Hide resolved

P403n1x87 force-pushed the chore/trigger-probe branch 3 times, most recently from f8ea66c to 07f7061 Compare October 31, 2024 11:46

P403n1x87 added 4 commits November 6, 2024 16:12

chore(di): trigger probes

876a8aa

We implement trigger probes. These allows triggering the capture of debug information along a trace, ensuring all the relevant probes are also triggered.

make conditional

325b1a4

adapt to refactor

533cd90

add rate limiter and propagation

a6af837

P403n1x87 force-pushed the chore/trigger-probe branch from 07f7061 to a6af837 Compare November 6, 2024 16:13

P403n1x87 added 3 commits November 7, 2024 10:30

make code origin for span opt-out

0b265ba

Merge remote-tracking branch 'origin/main' into chore/trigger-probe

334354a

session to trace linking fix and wrapper ordering

9edcbc1

P403n1x87 marked this pull request as ready for review December 19, 2024 11:28

P403n1x87 requested review from a team as code owners December 19, 2024 11:28

P403n1x87 requested a review from rachelyangdog December 19, 2024 11:28

P403n1x87 requested review from romainkomorn-exdatadog, emmettbutler and wantsui December 19, 2024 11:28

shatzi approved these changes Dec 19, 2024

View reviewed changes

emmettbutler approved these changes Dec 19, 2024

View reviewed changes

include changes from review

8401d1c

P403n1x87 force-pushed the chore/trigger-probe branch 2 times, most recently from 89c83aa to 118ecb1 Compare January 6, 2025 11:21

Merge branch 'main' into chore/trigger-probe

346a578

P403n1x87 force-pushed the chore/trigger-probe branch from 118ecb1 to 346a578 Compare January 6, 2025 14:57

avoid extraction for baggage

f108c5a

shatzi approved these changes Jan 9, 2025

View reviewed changes

ddtrace/debugging/_origin/span.py Outdated Show resolved Hide resolved

tests/debugging/test_session.py Show resolved Hide resolved

P403n1x87 added 2 commits January 9, 2025 10:35

fix start time

2d85475

Merge remote-tracking branch 'origin/main' into chore/trigger-probe

ae4cb76

P403n1x87 force-pushed the chore/trigger-probe branch from 30d613f to 33e9235 Compare January 22, 2025 11:34

shatzi approved these changes Jan 22, 2025

View reviewed changes

ddtrace/debugging/_session.py Show resolved Hide resolved

ddtrace/debugging/_probe/model.py Show resolved Hide resolved

ddtrace/debugging/_probe/remoteconfig.py Show resolved Hide resolved

add budget

a91ff4e

P403n1x87 force-pushed the chore/trigger-probe branch from 33e9235 to a91ff4e Compare January 23, 2025 11:46

P403n1x87 and others added 2 commits January 24, 2025 09:57

Merge branch 'main' into chore/trigger-probe

8dd170c

fix cos test

2ce7cb7

P403n1x87 enabled auto-merge (squash) January 27, 2025 14:10

erikayasuda force-pushed the main branch from 1247ac2 to 2ccaaef Compare February 6, 2025 20:43

ZStriker19 approved these changes Feb 10, 2025

View reviewed changes

P403n1x87 added 2 commits February 10, 2025 15:34

Merge branch 'main' into chore/trigger-probe

23fd710

Merge branch 'main' into chore/trigger-probe

57efadc

P403n1x87 merged commit 84949f3 into main Feb 12, 2025
739 checks passed

P403n1x87 deleted the chore/trigger-probe branch February 12, 2025 18:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(di): trigger probes #10942

chore(di): trigger probes #10942

P403n1x87 commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

pr-commenter bot commented Oct 4, 2024 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Oct 5, 2024 •

edited

Loading

shatzi left a comment

shatzi left a comment

shatzi left a comment

shatzi left a comment

datadog-dd-trace-py-rkomorn bot commented Jan 23, 2025 •

edited

Loading

chore(di): trigger probes #10942

chore(di): trigger probes #10942

Conversation

P403n1x87 commented Oct 4, 2024 • edited Loading

Checklist

Reviewer Checklist

github-actions bot commented Oct 4, 2024 • edited Loading

pr-commenter bot commented Oct 4, 2024 • edited Loading

Benchmarks

scenario:httppropagationextract-all_styles_all_headers

scenario:iast_aspects-ospathsplit_aspect

scenario:iast_aspects-ospathsplitext_aspect

datadog-dd-trace-py-rkomorn bot commented Oct 5, 2024 • edited Loading

Datadog Report

shatzi left a comment

Choose a reason for hiding this comment

shatzi left a comment

Choose a reason for hiding this comment

shatzi left a comment

Choose a reason for hiding this comment

shatzi left a comment

Choose a reason for hiding this comment

datadog-dd-trace-py-rkomorn bot commented Jan 23, 2025 • edited Loading

Datadog Report

P403n1x87 commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

pr-commenter bot commented Oct 4, 2024 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Oct 5, 2024 •

edited

Loading

datadog-dd-trace-py-rkomorn bot commented Jan 23, 2025 •

edited

Loading