Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable code origin for spans in django profile #10955

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Oct 5, 2024

We enable Code Origin for Spans in the Django profile job to collect profiling data with the featured turned on.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

We enable Code Origin for Spans in the Django profile job to collect
profiling data with the featured turned on.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 5, 2024
@P403n1x87 P403n1x87 self-assigned this Oct 5, 2024
@P403n1x87 P403n1x87 requested review from a team as code owners October 5, 2024 10:10
@P403n1x87 P403n1x87 enabled auto-merge (squash) October 5, 2024 10:10
Copy link
Contributor

github-actions bot commented Oct 5, 2024

CODEOWNERS have been resolved as:

.github/workflows/django-overhead-profile.yml                           @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Oct 5, 2024

Benchmarks

Benchmark execution time: 2024-10-05 10:51:31

Comparing candidate commit 303a52b in PR branch ci/django-profile-enable-code-origin-for-spans with baseline commit e0dd63b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 373 metrics, 53 unstable metrics.

@P403n1x87 P403n1x87 merged commit 0bf1fe9 into main Oct 7, 2024
509 of 510 checks passed
@P403n1x87 P403n1x87 deleted the ci/django-profile-enable-code-origin-for-spans branch October 7, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants