Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge suitespec and jobspec #11401

Merged
merged 11 commits into from
Nov 26, 2024
Merged

ci: merge suitespec and jobspec #11401

merged 11 commits into from
Nov 26, 2024

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Nov 13, 2024

We merge the suitespec and jobspec into a unique, modular solution that contains all the information to dynamically generate CI jobs based on the changes contained in a PR.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 13, 2024
@P403n1x87 P403n1x87 self-assigned this Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

CODEOWNERS have been resolved as:

tests/appsec/suitespec.yml                                              @DataDog/asm-python
tests/ci_visibility/suitespec.yml                                       @DataDog/ci-app-libraries
tests/contrib/suitespec.yml                                             @DataDog/apm-core-python @DataDog/apm-idm-python
tests/debugging/suitespec.yml                                           @DataDog/debugger-python
tests/llmobs/suitespec.yml                                              @DataDog/ml-observability
tests/suitespec.yml                                                     @DataDog/python-guild @DataDog/apm-core-python
.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.github/CODEOWNERS                                                      @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
docs/contributing-integrations.rst                                      @DataDog/python-guild
docs/contributing-testing.rst                                           @DataDog/python-guild
docs/spelling_wordlist.txt                                              @DataDog/python-guild
hatch.toml                                                              @DataDog/python-guild
scripts/gen_circleci_config.py                                          @DataDog/apm-core-python
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python
scripts/needs_testrun.py                                                @DataDog/apm-core-python
tests/README.md                                                         @DataDog/python-guild @DataDog/apm-core-python
tests/suitespec.py                                                      @DataDog/python-guild @DataDog/apm-core-python

@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024

Benchmarks

Benchmark execution time: 2024-11-26 21:47:07

Comparing candidate commit 8170ec0 in PR branch ci/make-suitespec-modular with baseline commit a098029 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 388 metrics, 2 unstable metrics.

@P403n1x87 P403n1x87 force-pushed the ci/make-suitespec-modular branch 5 times, most recently from 343b88c to 45793ba Compare November 14, 2024 14:12
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 15, 2024

Datadog Report

Branch report: ci/make-suitespec-modular
Commit report: 29d1504
Test service: dd-trace-py

❌ 2 Failed (0 Known Flaky), 58 Passed, 1508 Skipped, 1m 56.21s Total duration (36m 10.43s time saved)

❌ Failed Tests (2)

  • TestMysqlPatch::test_mysql_dbm_propagation_comment_integration_service_name_override - test_mysqldb.py - Details

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.mysqldb.test_mysqldb.TestMysqlPatch.test_mysql_dbm_propagation_comment_integration_service_name_override" Failed (exit code 1):
     /root/.pyenv/versions/3.12.4/lib/python3.12/socket.py:779: ResourceWarning: unclosed <socket.socket fd=3, family=2, type=1, proto=6, laddr=('127.0.0.1', 40288), raddr=('127.0.0.1', 9126)>
       self._sock = None
     ResourceWarning: Enable tracemalloc to get the object allocation traceback
     F
     ======================================================================
     FAIL: test_mysql_dbm_propagation_comment_integration_service_name_override (tests.contrib.mysqldb.test_mysqldb.TestMysqlPatch.test_mysql_dbm_propagation_comment_integration_service_name_override)
     tests if dbm comment is set in mysql
     ----------------------------------------------------------------------
     Traceback (most recent call last):
     ...
    
  • TestMysqlPatch::test_mysql_dbm_propagation_comment_integration_service_name_override - test_mysqldb.py - Details

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.mysqldb.test_mysqldb.TestMysqlPatch.test_mysql_dbm_propagation_comment_integration_service_name_override" Failed (exit code 1):
     /root/.pyenv/versions/3.8.19/lib/python3.8/socket.py:740: ResourceWarning: unclosed <socket.socket fd=3, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('127.0.0.1', 37910), raddr=('127.0.0.1', 9126)>
       self._sock = None
     ResourceWarning: Enable tracemalloc to get the object allocation traceback
     F
     ======================================================================
     FAIL: test_mysql_dbm_propagation_comment_integration_service_name_override (tests.contrib.mysqldb.test_mysqldb.TestMysqlPatch)
     tests if dbm comment is set in mysql
     ----------------------------------------------------------------------
     Traceback (most recent call last):
     ...
    

@P403n1x87 P403n1x87 force-pushed the ci/make-suitespec-modular branch 4 times, most recently from 9ee88ac to b53a333 Compare November 18, 2024 10:51
@P403n1x87 P403n1x87 marked this pull request as ready for review November 18, 2024 11:11
@P403n1x87 P403n1x87 requested review from a team as code owners November 18, 2024 11:11
We merge the suitespec and jobspec into a unique, modular solution that
contains all the information to dynamically generate CI jobs based on
the changes contained in a PR.
@P403n1x87 P403n1x87 enabled auto-merge (squash) November 26, 2024 16:24
@P403n1x87 P403n1x87 merged commit d386312 into main Nov 26, 2024
623 checks passed
@P403n1x87 P403n1x87 deleted the ci/make-suitespec-modular branch November 26, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants