Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add suitespec to GitLab [backport 2.15] #11451

Open
wants to merge 3 commits into
base: 2.15
Choose a base branch
from

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Nov 19, 2024

Backport f7c102e from #10877 to 2.17.

We port the suitespec machinery to GitLab. The current implementation uses generated child pipelines, with the tests YAML configuration automatically generated to include the required jobs based on the files listed in the PR. The job information previously contained in the config.templ.yaml file has been migrated to the jobspec.yml configuration. The jobspec can be "modular", in the sense that it can be split into multiple jobspec.yml file within the tests/ subtree (e.g. tests/jobspec.yml, tests/debugging/jobspec.yml, ...)

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 19, 2024
@erikayasuda erikayasuda requested review from a team as code owners November 19, 2024 22:17
Copy link
Contributor

CODEOWNERS have been resolved as:

.gitlab/testrunner.yml                                                  @DataDog/python-guild @DataDog/apm-core-python
.riot/requirements/196755b.txt                                          @DataDog/apm-python
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python
tests/README.md                                                         @DataDog/python-guild @DataDog/apm-core-python
tests/appsec/jobspec.yml                                                @DataDog/asm-python
tests/ci_visibility/jobspec.yml                                         @DataDog/ci-app-libraries
tests/contrib/jobspec.yml                                               @DataDog/apm-core-python @DataDog/apm-idm-python
tests/debugging/jobspec.yml                                             @DataDog/debugger-python
tests/jobspec.yml                                                       @DataDog/apm-core-python
tests/llmobs/jobspec.yml                                                @DataDog/ml-observability
.circleci/config.templ.yml                                              @DataDog/python-guild @DataDog/apm-core-python
.github/workflows/requirements-locks.yml                                @DataDog/python-guild @DataDog/apm-core-python
.gitignore                                                              @DataDog/apm-core-python
.gitlab-ci.yml                                                          @DataDog/apm-core-python
.gitlab/package.yml                                                     @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
docker-compose.yml                                                      @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
scripts/gen_circleci_config.py                                          @DataDog/apm-core-python
scripts/needs_testrun.py                                                @DataDog/apm-core-python
tests/.suitespec.json                                                   @DataDog/python-guild @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Nov 19, 2024

Datadog Report

Branch report: backport-10877-to-2.15
Commit report: 9588f25
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 694 Skipped, 19m 26.49s Total duration (15m 36.38s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 19, 2024

Benchmarks

Benchmark execution time: 2024-11-25 17:30:19

Comparing candidate commit 9588f25 in PR branch backport-10877-to-2.15 with baseline commit dad1ed0 in branch 2.15.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 372 metrics, 52 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants