Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(asm): standalone missing tag [backport 2.16] #11488

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix(asm): standalone missing tag [backport 2.16] #11488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ddtrace/_trace/processor/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,9 @@ def process_trace(self, trace: List[Span]) -> Optional[List[Span]]:
root_ctx = chunk_root._context

if self.apm_opt_out:
chunk_root.set_metric(MK_APM_ENABLED, 0)
for span in trace:
if span._local_root_value is None:
span.set_metric(MK_APM_ENABLED, 0)

# only trace sample if we haven't already sampled
if root_ctx and root_ctx.sampling_priority is None:
Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/fix_asm_standalone_span_tag-60b38c1d9d2efbaa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
fixes:
- |
ASM: This fix resolves an issue where some root span where not appropriately tagged for ASM standalone.
Loading