Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracing): fix some service naming tests that were failing silently [backport 2.17] #11542

Merged
merged 2 commits into from
Nov 26, 2024

Commits on Nov 25, 2024

  1. chore(tracing): fix some service naming tests that were failing silen…

    …tly (#11483)
    
    ## Motivation
    
    See silent failures
    [here](https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/714753885#L6693).
    
    DOES NOT NEED TO BE BACKPORTED, FIX WAS ALREADY INCLUDED IN EARLIER
    BACKPORT PR
    
    ## Checklist
    - [x] PR author has checked that all the criteria below are met
    - The PR description includes an overview of the change
    - The PR description articulates the motivation for the change
    - The change includes tests OR the PR description describes a testing
    strategy
    - The PR description notes risks associated with the change, if any
    - Newly-added code is easy to change
    - The change follows the [library release note
    guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
    - The change includes or references documentation updates if necessary
    - Backport labels are set (if
    [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
    
    ## Reviewer Checklist
    - [x] Reviewer has checked that all the criteria below are met
    - Title is accurate
    - All changes are related to the pull request's stated goal
    - Avoids breaking
    [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
    changes
    - Testing strategy adequately addresses listed risks
    - Newly-added code is easy to change
    - Release note makes sense to a user of the library
    - If necessary, author has acknowledged and discussed the performance
    implications of this PR as reported in the benchmarks PR comment
    - Backport labels are set in a manner that is consistent with the
    [release branch maintenance
    policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
    
    (cherry picked from commit 81f52ca)
    wconti27 authored and github-actions[bot] committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fb96e38 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Configuration menu
    Copy the full SHA
    f9a430e View commit details
    Browse the repository at this point in the history