Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix last version calculation for release script #11988

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Jan 16, 2025

Small bug in the release script where if the tens place bumped up, the last version calculation would fail.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda requested a review from a team as a code owner January 16, 2025 19:12
@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 16, 2025
@erikayasuda erikayasuda reopened this Jan 16, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

scripts/release.py                                                      @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: erikayasuda/update-release-script
Commit report: 72b4b10
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 39.72s Total duration (35m 32.52s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025

Benchmarks

Benchmark execution time: 2025-01-16 19:53:10

Comparing candidate commit 72b4b10 in PR branch erikayasuda/update-release-script with baseline commit b028cc6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant