Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llmobs): remove public notice of submit_evaluation_for #11997

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lievan
Copy link
Contributor

@lievan lievan commented Jan 17, 2025

We're holding off on a public release of joining by tag for evaluation metrics. This PR removes the deprecation notice for submit_evaluation, the predecessor to submit_evaluation_for, and removes the release note for submit_evaluation_for.

We don't revert the entire original PR because:

  • any urgent customers blocked on joining by tag can use submit_evaluation_for in an "early access" mode
  • we still want to keep the changes that updates the eval metric writer to write to the v2 eval metric endpoint

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@lievan lievan added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 17, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/llmobs/_llmobs.py                                               @DataDog/ml-observability

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: evan.li/submit-eval-rel
Commit report: 0e8c420
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 57.44s Total duration (35m 43.36s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 17, 2025

Benchmarks

Benchmark execution time: 2025-01-17 21:05:58

Comparing candidate commit 6cdde17 in PR branch evan.li/submit-eval-rel with baseline commit ef4c997 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@lievan lievan marked this pull request as ready for review January 17, 2025 17:23
@lievan lievan requested review from a team as code owners January 17, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant