-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add allcheckspassed GitHub action #9427
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 121411 Passed, 54483 Skipped, 4h 49m 44.78s Total duration (5h 2m 58.28s time saved) New Flaky Tests (13)
|
|
So it does not have a list of checks to expect? |
No, I actually think this isn't going to work for us..... I am testing out a few ideas |
This tool isn't going to work with us. It'll mark the PR as green as long as the currently reported checks are all green, but it doesn't have the ability to wait until a specific check has completed before checking. GitLab won't report job status until the job has finished. |
Adds a new GitHub Action allcheckspassed, which will poll and check that all GitHub Action jobs that run are passing.
This will allow us to not need to specify every job in the branch protection rules (aside from this one).
This makes it easier to work with jobs that only run when specific files change. e.g. lib-injection jobs don't always run, so they cannot be added to branch protection rules, but if they do run, then we should enforce that they pass.
Anything which was not required before will not become required unless we put them in an exclude list.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist