Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add allcheckspassed GitHub action #9427

Closed
wants to merge 11 commits into from

Conversation

brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented May 29, 2024

Adds a new GitHub Action allcheckspassed, which will poll and check that all GitHub Action jobs that run are passing.

This will allow us to not need to specify every job in the branch protection rules (aside from this one).

This makes it easier to work with jobs that only run when specific files change. e.g. lib-injection jobs don't always run, so they cannot be added to branch protection rules, but if they do run, then we should enforce that they pass.

Anything which was not required before will not become required unless we put them in an exclude list.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label May 29, 2024
@brettlangdon brettlangdon requested a review from a team as a code owner May 29, 2024 12:10
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: brettlangdon/allchecks
Commit report: ae93502
Test service: dd-trace-py

✅ 0 Failed, 121411 Passed, 54483 Skipped, 4h 49m 44.78s Total duration (5h 2m 58.28s time saved)
❄️ 13 New Flaky

New Flaky Tests (13)

  • test_aiomysql_dbm_propagation_comment_with_global_service_name_configured - test_aiomysql.py - Last Failure

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.aiomysql.test_aiomysql.AioMySQLTestCase.test_aiomysql_dbm_propagation_comment_with_global_service_name_configured" Failed (exit code 1):
     E/root/.pyenv/versions/3.11.3/lib/python3.11/unittest/case.py:584: RuntimeWarning: coroutine 'AioMySQLTestCase.tearDown' was never awaited
       self.tearDown()
     RuntimeWarning: Enable tracemalloc to get the object allocation traceback
     
     ======================================================================
     ERROR: test_aiomysql_dbm_propagation_comment_with_global_service_name_configured (tests.contrib.aiomysql.test_aiomysql.AioMySQLTestCase.test_aiomysql_dbm_propagation_comment_with_global_service_name_configured)
     tests if dbm comment is set in mysql
     ----------------------------------------------------------------------
     Traceback (most recent call last):
     ...
    
  • test_span_name_v1_schema - test_aiomysql.py - Last Failure

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.aiomysql.test_aiomysql.AioMySQLTestCase.test_span_name_v1_schema" Failed (exit code 1):
     E/root/.pyenv/versions/3.11.3/lib/python3.11/unittest/case.py:584: RuntimeWarning: coroutine 'AioMySQLTestCase.tearDown' was never awaited
       self.tearDown()
     RuntimeWarning: Enable tracemalloc to get the object allocation traceback
     
     ======================================================================
     ERROR: test_span_name_v1_schema (tests.contrib.aiomysql.test_aiomysql.AioMySQLTestCase.test_span_name_v1_schema)
     ----------------------------------------------------------------------
     Traceback (most recent call last):
       File "/root/project/.riot/venv_py3113_mock_pytest_pytest-mock_coverage_pytest-cov_opentracing_hypothesis6451_pytest-randomly_pytest-asyncio0211_aiomysql/lib/python3.11/site-packages/aiomysql/connection.py", line 527, in _connect
     ...
    
  • test_user_specified_service_v0 - test_aiomysql.py - Last Failure

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.aiomysql.test_aiomysql.AioMySQLTestCase.test_user_specified_service_v0" Failed (exit code 1):
     E/root/.pyenv/versions/3.11.3/lib/python3.11/unittest/case.py:584: RuntimeWarning: coroutine 'AioMySQLTestCase.tearDown' was never awaited
       self.tearDown()
     RuntimeWarning: Enable tracemalloc to get the object allocation traceback
     
     ======================================================================
     ERROR: test_user_specified_service_v0 (tests.contrib.aiomysql.test_aiomysql.AioMySQLTestCase.test_user_specified_service_v0)
     ----------------------------------------------------------------------
     Traceback (most recent call last):
       File "/root/project/.riot/venv_py3113_mock_pytest_pytest-mock_coverage_pytest-cov_opentracing_hypothesis6451_pytest-randomly_pytest-asyncio0211_aiomysql/lib/python3.11/site-packages/aiomysql/connection.py", line 527, in _connect
     ...
    
  • test_schematized_default_db_service_name[None-mysvc] - test_django.py - Last Failure

    Expand for error
     (b'============================= test session starts ==============================
       platform linux -- Python 3.8.16, ...==========
       ', b'failed to send, dropping 452 traces to intake at http://localhost:9126/v0.5/traces after 3 retries
       ')
     assert 1 == 0
    
  • test_and_emit_get_version - test_loguru_patch.py - Last Failure

    Expand for error
     Subprocess Test "python -m unittest tests.contrib.loguru.test_loguru_patch.TestLoguruPatch.test_and_emit_get_version" Failed (exit code 1):
     E
     ======================================================================
     ERROR: test_and_emit_get_version (tests.contrib.loguru.test_loguru_patch.TestLoguruPatch.test_and_emit_get_version)
     Each contrib module should implement a get_version() function. This function is used for
     ----------------------------------------------------------------------
     Traceback (most recent call last):
       File "/root/project/tests/contrib/patch.py", line 788, in test_and_emit_get_version
         emit_integration_and_version_to_test_agent(
       File "/root/project/tests/contrib/patch.py", line 120, in emit_integration_and_version_to_test_agent
     ...
    

@brettlangdon brettlangdon enabled auto-merge (squash) May 29, 2024 13:20
@pr-commenter
Copy link

pr-commenter bot commented Jul 15, 2024

Benchmarks

Benchmark execution time: 2024-08-21 18:23:50

Comparing candidate commit 038cfac in PR branch brettlangdon/allchecks with baseline commit 4d1e946 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@brettlangdon brettlangdon requested a review from a team as a code owner August 21, 2024 17:30
@brettlangdon brettlangdon changed the title chore(ci): add All checks pass GitHub action chore(ci): add allcheckspassed GitHub action Aug 21, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/all_checks_pass.yml                                   @DataDog/python-guild @DataDog/apm-core-python

@brettlangdon brettlangdon marked this pull request as draft August 21, 2024 17:41
@romainkomorndatadog
Copy link
Collaborator

which will poll and check that all GitHub Action jobs that run are passing

So it does not have a list of checks to expect?

@brettlangdon
Copy link
Member Author

which will poll and check that all GitHub Action jobs that run are passing

So it does not have a list of checks to expect?

No, I actually think this isn't going to work for us..... I am testing out a few ideas

@brettlangdon
Copy link
Member Author

This tool isn't going to work with us. It'll mark the PR as green as long as the currently reported checks are all green, but it doesn't have the ability to wait until a specific check has completed before checking.

GitLab won't report job status until the job has finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants