Louiszawadzki/improve expo documentation #19706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
jhgilbert
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR clarifies the Expo documentation following a few issue reported.
Motivation
The usage section of the main docs were misleading: it was unclear that developers must add
@datadog/datadog-cias a dependency if they use the config plugin as this was partially duplicated in the documentation. It was reported here: DataDog/dd-sdk-reactnative#524The part about disabling file uploads only covered partially disabling file uploads, but not disabling all file uploads. This was reported here: DataDog/expo-datadog#2
Merge instructions
Additional Notes
Reviewer checklist
cache_enabledis set totruein thepull_config_preview.yamlfile