[RUM-4060] Fix datadog-ci path resolving on iOS scripts #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a better way to resolve the
datadog-ci
executable path, taking advantage of the node resolver.Motivation
The iOS scripts added to the build phases by the Datadog Expo plugin depend on
datadog-ci
and they currently use a relative path, assuming that the cwd at execution time will always be the same, while it can actually vary depending on the setup.Additional Notes
The core of the PR is:
This approach conforms to how Expo resolves paths, and it also allows to override
DATADOG_CI_EXEC
if ever needed.Review checklist (to be filled by reviewers)