This repository was archived by the owner on Aug 10, 2022. It is now read-only.
Add PyBytes_FromStringAndSize to allow strings with NUL characters to be processed #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a wrapper function for
C.PyBytes_FromStringAndSize
that explicitly uses the Go string's length. This allows to correctly turn Go strings into Pythonbytes
objects even when they contain NUL characters.Motivation
I wrote code that receives binary protobuf messages and hands them over to python code that in turn parses it into a python object and then processes the message. I noticed that when I used
python3.PyBytes_FromString
to turn the binary message into a pythonbytes
object, it got truncated at NUL characters, which caused failures when decoding. Upon closer inspection, I noticed that this was inherent in howPyBytes_FromString
worked, so I created this PR to fix this shortcoming.Additional Notes
None.