Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add talos support for os-release files #1611

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented Nov 21, 2024

What this PR does / why we need it:

Based on #1572,

  • Added the configuration value datadog.disablePasswdMount to disable mounting the /etc/passwd path from the host filesystem. This option should be used when the underlying OS does not have these files (e.g., Talos OS).
  • Added the configuration value datadog.disableDefaultOsReleasePaths to disable mounting the default "os-release" file paths from the host filesystem (e.g., /etc/redhat-release, /etc/fedora-release, etc.). Note that this change does not affect the datadog.osReleasePath option. To avoid mounting the /etc/os-release host path, set the datadog.osReleasePath configuration value to an empty string. This option should be used when the underlying OS does not have these files (e.g., Talos OS).
  • Add providers.talos.enabled to simplify agent deployment configuration on Talos OS.
  • Let the end user know when an incompatible options is set with datadog.disableDefaultOsReleasePaths set to true.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

tested locally in a kind cluster with different setup

  • check that with providers.talos.enabled:true the /etc/passwd host file is not mounted
datadog:
  apiKeyExistingSecret: datadog-secret-api
  appKeyExistingSecret: datadog-secret-app
  kubelet:
    tlsVerify: false

providers:
  talos:
    enabled: true
  • check that /etc/os-release is not mounted if datadog.osReleasePath is set to an empty string
datadog:
  apiKeyExistingSecret: datadog-secret-api
  appKeyExistingSecret: datadog-secret-app
  kubelet:
    tlsVerify: false

  osReleasePath: ""  # check if removing the default value make the volume to not be mounted

providers:
  talos:
    enabled: true
  • check that talos provider option is compatible with datadog.sbom.host.enabled:true
datadog:
  apiKeyExistingSecret: datadog-secret-api
  appKeyExistingSecret: datadog-secret-app
  kubelet:
    tlsVerify: false

  sbom:
    host:
      enabled: true

providers:
  talos:
    enabled: true

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@clamoriniere clamoriniere requested review from a team as code owners November 21, 2024 14:00
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Nov 21, 2024
@clamoriniere clamoriniere force-pushed the clamoriniere/talos-support branch 3 times, most recently from 6299ab1 to 74ba435 Compare November 21, 2024 21:00
@clamoriniere clamoriniere force-pushed the clamoriniere/talos-support branch 2 times, most recently from 1b82eaa to 8f2e2e5 Compare November 21, 2024 22:42
Comment on lines +1056 to +1057
{{- else if .Values.providers.talos.enabled -}}
false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the PR #1572, you find that in talos the os-release file is present.
Maybe disabling this mount isn't mandatory when talos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants