Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datadog): rename ci values files to be properly tested #1612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented Nov 21, 2024

What this PR does / why we need it:

rename some datadog ci values.yaml files to add the values.yaml prefix.
to be executed in the ci testing, the file need to finish by -values.yaml

 rename charts/datadog/ci/{agent-sbom-snapshotter.yaml => agent-sbom-snapshotter-values.yaml} (100%)
 rename charts/datadog/ci/{autoscaling.yaml => autoscaling-values.yaml} (100%)
 rename charts/datadog/ci/{image-digest.yaml => image-digest-values.yaml} (93%)
 rename charts/datadog/ci/{otlp-ingest.yaml => otlp-ingest-values.yaml} (80%)

then fix several issues in the files like

charts/datadog/ci/otlp-ingest-values.yaml
  Error: 6:10 [indentation] wrong indentation: expected 10 but found 9

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

I haven't update the chart and changelog, since this PR doesn't modify the options or docs.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@clamoriniere clamoriniere requested a review from a team as a code owner November 21, 2024 21:36
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Nov 21, 2024
@clamoriniere clamoriniere force-pushed the clamoriniere/fix-datadog-ci-files branch 4 times, most recently from 22131c8 to 9b0fc3b Compare November 21, 2024 22:09
@clamoriniere clamoriniere force-pushed the clamoriniere/fix-datadog-ci-files branch from 9b0fc3b to 2accc95 Compare November 21, 2024 22:51
@clamoriniere
Copy link
Collaborator Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 22, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-22 08:33:04 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 37m.


2024-11-22 10:33:20 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build took longer than expected. The current limit for the base branch 'main' is 120 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart mergequeue-status: rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants