-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDSaaS: Okta Workflows: Crawler Integration v1.0.0 #19296
Open
DhruvaPatel-crest
wants to merge
18
commits into
DataDog:master
Choose a base branch
from
bhargavnariyanicrest:okta_workflows-assets-V1.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DDSaaS: Okta Workflows: Crawler Integration v1.0.0 #19296
DhruvaPatel-crest
wants to merge
18
commits into
DataDog:master
from
bhargavnariyanicrest:okta_workflows-assets-V1.0.0
+3,293
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brett0000FF
previously approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for Docs given "display_on_public_website": false
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
Jan 28, 2025
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
Jan 29, 2025
brett0000FF
reviewed
Jan 29, 2025
abhi-modugula
previously approved these changes
Jan 29, 2025
Co-authored-by: Brett Blue <[email protected]>
Co-authored-by: Brett Blue <[email protected]>
Co-authored-by: Brett Blue <[email protected]>
Co-authored-by: Brett Blue <[email protected]>
Kyle-Neale
previously approved these changes
Jan 29, 2025
brett0000FF
previously approved these changes
Jan 29, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
Jan 29, 2025
avaid-crest
dismissed stale reviews from brett0000FF and Kyle-Neale
via
January 30, 2025 05:50
f4c697e
temporal-github-worker-1
bot
added
agent/review-requested
docs/review-requested
and removed
agent/approved
docs/approved
labels
Jan 30, 2025
abhi-modugula
approved these changes
Jan 30, 2025
brett0000FF
approved these changes
Jan 30, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
Jan 30, 2025
BoyangHuang
added
the
assets/deploy-logs-staging
ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging
label
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
agent/review-requested
assets/deploy-logs-staging
ONLY USED BY Logs Backend - Validates that a PR is OK to go to staging
docs/approved
ecosystems/review-requested
product/review-requested
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is an initial release PR of Okta Workflows integration including all the required assets.
Additional Notes
Crawler code for this integration has been committed in its respective repo
Pipeline and Facet group created for this integration are available in our sandbox and would be shared separately with the required teams.
Samples for the pipeline review would also be shared separately with the required teams.
Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behavior.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged