Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eci][oci] create oci oke OOTB dashboard #19373

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[eci][oci] create oci oke OOTB dashboard #19373

wants to merge 6 commits into from

Conversation

natwilkinson
Copy link
Contributor

@natwilkinson natwilkinson commented Jan 10, 2025 •
edited
Loading

What does this PR do?

  • adds an OOTB dashboard for OCI OKE

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@natwilkinson natwilkinson requested review from a team as code owners January 10, 2025 20:29
@jhgilbert jhgilbert self-assigned this Jan 10, 2025
jhgilbert
jhgilbert reviewed Jan 10, 2025
View reviewed changes
oke/assets/dashboards/oci_oke_overview.json Outdated Show resolved Hide resolved
oke/assets/dashboards/oci_oke_overview.json Outdated Show resolved Hide resolved
oke/assets/dashboards/oci_oke_overview.json Outdated Show resolved Hide resolved
iliakur
iliakur previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but docs had some input.

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.58%. Comparing base (bd8de59) to head (7aa1f2b).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed iliakur’s stale review January 16, 2025 16:12

Stale Review dismissed by prbot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhgilbert jhgilbert jhgilbert approved these changes

@iliakur iliakur iliakur left review comments

Assignees

@jhgilbert jhgilbert

Labels
agent/approved docs/approved ecosystems/review-requested product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natwilkinson @iliakur @jhgilbert