Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Milvus overview dashboard #19392

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dkirov-dd
Copy link
Contributor

@dkirov-dd dkirov-dd commented Jan 14, 2025

What does this PR do?

Adds an overview dashboard for Milvus.
See here

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dkirov-dd dkirov-dd requested review from a team as code owners January 14, 2025 13:31
@maycmlee
Copy link
Contributor

maycmlee commented Jan 14, 2025

Created DOCS-9875 for docs review.

@maycmlee maycmlee added the editorial review Waiting on a more in-depth review from a docs team editor label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (18d32c1) to head (4097758).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@neko-dd neko-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions but over LGTM

milvus/assets/dashboards/milvus_overview.json Outdated Show resolved Hide resolved
milvus/assets/dashboards/milvus_overview.json Outdated Show resolved Hide resolved
milvus/assets/dashboards/milvus_overview.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review from a docs team editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants