Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GHA on aarch64 runners #158

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix GHA on aarch64 runners #158

merged 2 commits into from
Dec 18, 2024

Conversation

jbachorik
Copy link
Collaborator

@jbachorik jbachorik commented Dec 17, 2024

What does this PR do?:
It fixes the encoding of DWARF CFA values to take negative offsets into account.
It also adds some defensive excludes for Asan on aarch64 because they seem to be false positives, specifically on the GHA aarch64 runners (was not able to reproduce on a different aarch64 box)

Motivation:
Make the sanity runs stable again on aarch64

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: PROF-11043

Unsure? Have a question? Request a review!

Copy link

🔧 Report generated by pr-comment-scanbuild

Scan-Build Report

User:runner@fv-az1934-63
Working Directory:/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:make -j4 clean all
Clang Version:Ubuntu clang version 18.1.3 (1ubuntu1)
Date:Tue Dec 17 15:07:03 2024

Bug Summary

Bug TypeQuantityDisplay?
All Bugs5
Logic error
Dereference of null pointer3
Suspicious operation
Bitwise shift1
Unused code
Dead nested assignment1

Reports

Bug Group Bug Type ▾ File Function/Method Line Path Length
Suspicious operationBitwise shiftvmStructs.cppfind84616
Unused codeDead nested assignmentvmStructs.cppcheckNativeBinding9511
Logic errorDereference of null pointersafeAccess.hload3318
Logic errorDereference of null pointersymbols_linux.hElfParser12928
Logic errorDereference of null pointerflightRecorder.cppflush15048

Copy link

🔧 Report generated by pr-comment-cppcheck

CppCheck Report

Warnings (7)

Style Violations (402)

@jbachorik jbachorik merged commit deff712 into main Dec 18, 2024
39 checks passed
@jbachorik jbachorik deleted the jb/fix_aarch64_gha branch December 18, 2024 09:09
@github-actions github-actions bot added this to the 1.18.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant