-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly manage JNI resources in JVMTI wallclock sampler #168
Draft
jbachorik
wants to merge
4
commits into
main
Choose a base branch
from
jb/wallclock_interval
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
🔧 Report generated by pr-comment-scanbuild Scan-Build Report
Bug Summary
Reports
|
Thanks for figuring things out! I'll try to run things to see how it behaves. |
r1viollet
reviewed
Jan 17, 2025
r1viollet
reviewed
Jan 17, 2025
r1viollet
reviewed
Jan 17, 2025
r1viollet
reviewed
Jan 17, 2025
r1viollet
reviewed
Jan 17, 2025
r1viollet
reviewed
Jan 17, 2025
027351d
to
61248da
Compare
61248da
to
522c37e
Compare
I have found some weird behaviour in JVMTI, especially when I try using RAII objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
It fixes the issue with the JVMTI wallclock sampler keep all threads in the system alive indefinitely
Motivation:
Resolve the corresponding memory leak. Make JVMTI wallclock sampler usable.
Additional Notes:
Due to stricter checks for thread state before collecting stacktrace and proper resource management, the #167 is not necessary any more.
How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!