Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBM J9 8u361 corresponds to OpenJDK 8u362 #187

Merged
merged 2 commits into from
Feb 21, 2025
Merged

IBM J9 8u361 corresponds to OpenJDK 8u362 #187

merged 2 commits into from
Feb 21, 2025

Conversation

jbachorik
Copy link
Collaborator

@jbachorik jbachorik commented Feb 21, 2025

What does this PR do?:
It modifies the check in can_use_ASGCT to include the closed-source version of IBM J9

Motivation:
We are not able to extract the exact version information from IBM J9 - we are using the date tag to assert whether it is after 8u361 or before.
However, the ASGCT check was based on the open source version 8.0.362 which corresponds to the closed source version 8.0.361 (or 8u361)

How to test the change?:
Running
For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@jbachorik jbachorik marked this pull request as ready for review February 21, 2025 10:51
Copy link

github-actions bot commented Feb 21, 2025

🔧 Report generated by pr-comment-scanbuild

Scan-Build Report

User:runner@fv-az1937-158
Working Directory:/home/runner/work/java-profiler/java-profiler/ddprof-lib/src/test/make
Command Line:make -j4 clean all
Clang Version:Ubuntu clang version 18.1.3 (1ubuntu1)
Date:Fri Feb 21 12:12:28 2025

Bug Summary

Bug TypeQuantityDisplay?
All Bugs7
Logic error
Dereference of null pointer3
Suspicious operation
Bitwise shift1
Unused code
Dead initialization2
Dead nested assignment1

Reports

Bug Group Bug Type ▾ File Function/Method Line Path Length
Suspicious operationBitwise shiftvmStructs.cppfind89716
Unused codeDead initializationjavaApi.cppJava_com_datadoghq_profiler_JavaProfiler_getStatus01161
Unused codeDead initializationstackWalker.cppwalkDwarf1601
Unused codeDead nested assignmentvmStructs.cppcheckNativeBinding10021
Logic errorDereference of null pointersafeAccess.hload3318
Logic errorDereference of null pointersymbols_linux.hElfParser14428
Logic errorDereference of null pointerflightRecorder.cppflush15048

Copy link

github-actions bot commented Feb 21, 2025

🔧 Report generated by pr-comment-cppcheck

CppCheck Report

Warnings (7)

Style Violations (398)

@jbachorik jbachorik merged commit 4595318 into main Feb 21, 2025
83 checks passed
@github-actions github-actions bot added this to the 1.22.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant