Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources are only dd.internal.resource tags #829

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

resources are only dd.internal.resource tags #829

wants to merge 2 commits into from

Conversation

alexgallotta
Copy link
Contributor

avoid sending duplicates tags as resources when they are not prefixed with dd.internal.resource

@alexgallotta alexgallotta requested a review from a team as a code owner January 16, 2025 20:07
duncanista
duncanista reviewed Jan 16, 2025
View reviewed changes
dogstatsd/src/metric.rs
resources.push(resource);
for (key, val) in &self.values {
if key == "dd.internal.resource" {
//anything coming in via dd.internal.resource:<value> has to be a key/value pair
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how was this not caught in testing? is there only unit testing and not integration testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only way to get this in testing would be with a proper json/binary payload to compare, which is not done afaik

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-01-16 20:23:30

Comparing candidate commit a9b35eb in PR branch fix-resource-tag with baseline commit b64c404 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.270µs 4.285µs ± 0.003µs 4.285µs ± 0.001µs 4.286µs 4.290µs 4.291µs 4.292µs 0.17% -0.587 4.922 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 232996194.296op/s 233382941.302op/s ± 141824.502op/s 233382484.647op/s ± 61795.042op/s 233441552.607op/s 233613021.203op/s 233663884.570op/s 234192084.468op/s 0.35% 0.599 4.977 0.06% 10028.507op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 110.893µs 111.296µs ± 0.217µs 111.276µs ± 0.136µs 111.413µs 111.620µs 111.787µs 112.746µs 1.32% 1.596 8.686 0.19% 0.015µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8869512.617op/s 8985107.614op/s ± 17467.929op/s 8986695.204op/s ± 10968.694op/s 8996982.637op/s 9009791.122op/s 9016685.268op/s 9017679.160op/s 0.34% -1.549 8.320 0.19% 1235.169op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 101.228µs 101.600µs ± 0.160µs 101.594µs ± 0.100µs 101.701µs 101.846µs 101.988µs 102.468µs 0.86% 0.774 3.387 0.16% 0.011µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 9759146.242op/s 9842540.986op/s ± 15529.235op/s 9843112.720op/s ± 9650.836op/s 9851377.542op/s 9866069.896op/s 9873218.459op/s 9878648.290op/s 0.36% -0.751 3.277 0.16% 1098.083op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.273µs 4.286µs ± 0.003µs 4.286µs ± 0.001µs 4.287µs 4.291µs 4.294µs 4.295µs 0.22% 0.285 3.501 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 232829079.813op/s 233317872.709op/s ± 154063.959op/s 233342562.728op/s ± 54998.267op/s 233389083.226op/s 233541328.718op/s 233646877.647op/s 234052116.006op/s 0.30% -0.274 3.521 0.07% 10893.967op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 97.577µs 97.870µs ± 0.121µs 97.893µs ± 0.075µs 97.949µs 98.055µs 98.103µs 98.219µs 0.33% -0.253 -0.262 0.12% 0.009µs 1 200
credit_card/is_card_number/378282246310005 throughput 10181278.152op/s 10217616.804op/s ± 12684.051op/s 10215241.080op/s ± 7807.700op/s 10226571.174op/s 10241039.774op/s 10244700.705op/s 10248323.852op/s 0.32% 0.259 -0.263 0.12% 896.898op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 70.931µs 71.319µs ± 0.123µs 71.339µs ± 0.077µs 71.411µs 71.484µs 71.519µs 71.539µs 0.28% -0.792 0.319 0.17% 0.009µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 13978386.638op/s 14021582.938op/s ± 24137.530op/s 14017531.359op/s ± 15063.765op/s 14034352.216op/s 14068953.337op/s 14089152.865op/s 14098303.974op/s 0.58% 0.801 0.337 0.17% 1706.781op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.835µs 6.842µs ± 0.003µs 6.842µs ± 0.001µs 6.844µs 6.847µs 6.850µs 6.852µs 0.14% 0.325 1.475 0.04% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145945427.391op/s 146146655.638op/s ± 60978.149op/s 146150893.300op/s ± 26111.032op/s 146175712.905op/s 146261042.780op/s 146293864.487op/s 146306745.401op/s 0.11% -0.321 1.472 0.04% 4311.806op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.270µs 4.285µs ± 0.002µs 4.285µs ± 0.001µs 4.286µs 4.289µs 4.291µs 4.295µs 0.24% -0.805 9.631 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 232809525.201op/s 233372137.262op/s ± 128510.818op/s 233378855.882op/s ± 52656.959op/s 233430427.656op/s 233547010.837op/s 233701961.923op/s 234201625.323op/s 0.35% 0.823 9.712 0.05% 9087.087op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 84.543µs 84.833µs ± 0.132µs 84.829µs ± 0.086µs 84.916µs 85.055µs 85.150µs 85.204µs 0.44% 0.223 -0.110 0.15% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 11736519.513op/s 11787929.248op/s ± 18283.459op/s 11788446.733op/s ± 11985.524op/s 11800124.197op/s 11817219.824op/s 11828075.261op/s 11828332.405op/s 0.34% -0.214 -0.116 0.15% 1292.836op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 74.335µs 74.665µs ± 0.135µs 74.678µs ± 0.096µs 74.737µs 74.880µs 74.953µs 75.094µs 0.56% 0.034 -0.165 0.18% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 13316662.991op/s 13393237.603op/s ± 24248.047op/s 13390793.832op/s ± 17210.748op/s 13409434.550op/s 13436458.891op/s 13443523.300op/s 13452580.757op/s 0.46% -0.025 -0.172 0.18% 1714.596op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.269µs 4.285µs ± 0.003µs 4.285µs ± 0.001µs 4.286µs 4.289µs 4.292µs 4.310µs 0.59% 2.446 24.876 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 231992639.850op/s 233345356.448op/s ± 170841.251op/s 233365111.916op/s ± 58285.883op/s 233409593.135op/s 233524590.042op/s 233719329.091op/s 234236811.007op/s 0.37% -2.400 24.624 0.07% 12080.301op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 70.519µs 70.850µs ± 0.135µs 70.851µs ± 0.078µs 70.922µs 71.078µs 71.176µs 71.260µs 0.58% 0.022 0.369 0.19% 0.010µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 14033204.142op/s 14114365.776op/s ± 26974.378op/s 14114111.398op/s ± 15552.549op/s 14129865.354op/s 14160518.382op/s 14177273.959op/s 14180589.609op/s 0.47% -0.008 0.366 0.19% 1907.377op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 70.847µs 71.312µs ± 0.151µs 71.326µs ± 0.098µs 71.423µs 71.501µs 71.537µs 72.110µs 1.10% 0.086 3.447 0.21% 0.011µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 13867673.479op/s 14022985.575op/s ± 29751.785op/s 14020128.043op/s ± 19278.547op/s 14039229.108op/s 14076025.502op/s 14109835.707op/s 14114862.951op/s 0.68% -0.052 3.322 0.21% 2103.769op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.833µs 6.843µs ± 0.004µs 6.843µs ± 0.002µs 6.845µs 6.850µs 6.855µs 6.866µs 0.34% 1.202 4.950 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145637475.252op/s 146125019.887op/s ± 86917.340op/s 146138526.830op/s ± 37799.915op/s 146170287.244op/s 146245407.814op/s 146309121.811op/s 146348953.965op/s 0.14% -1.192 4.903 0.06% 6145.984op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.284µs; 4.285µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ throughput [233363285.790op/s; 233402596.814op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [111.266µs; 111.326µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8982686.727op/s; 8987528.501op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [101.578µs; 101.622µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9840388.784op/s; 9844693.189op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number/37828224631 execution_time [4.286µs; 4.286µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [233296520.926op/s; 233339224.492op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [97.853µs; 97.887µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/378282246310005 throughput [10215858.916op/s; 10219374.691op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [71.302µs; 71.336µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [14018237.708op/s; 14024928.167op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.842µs; 6.843µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number/x371413321323331 throughput [146138204.653op/s; 146155106.623op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.285µs; 4.285µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ throughput [233354326.899op/s; 233389947.625op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [84.815µs; 84.851µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [11785395.336op/s; 11790463.160op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [74.646µs; 74.684µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [13389877.057op/s; 13396598.149op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.285µs; 4.286µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [233321679.494op/s; 233369033.402op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [70.831µs; 70.869µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [14110627.387op/s; 14118104.165op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [71.291µs; 71.333µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [14018862.264op/s; 14027108.887op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.843µs; 6.844µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146112973.979op/s; 146137065.794op/s] or [-0.008%; +0.008%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.740µs 2.781µs ± 0.019µs 2.779µs ± 0.015µs 2.797µs 2.813µs 2.820µs 2.825µs 1.66% 0.305 -0.866 0.68% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.778µs; 2.784µs] or [-0.094%; +0.094%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.394µs 3.286µs ± 1.461µs 3.088µs ± 0.025µs 3.113µs 3.728µs 14.259µs 15.330µs 396.50% 7.475 56.469 44.36% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.083µs; 3.488µs] or [-6.163%; +6.163%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 297.442ns 308.169ns ± 14.124ns 302.397ns ± 3.371ns 308.437ns 343.328ns 345.439ns 346.603ns 14.62% 1.744 1.537 4.57% 0.999ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [306.212ns; 310.127ns] or [-0.635%; +0.635%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.410µs 5.471µs ± 0.034µs 5.469µs ± 0.029µs 5.502µs 5.524µs 5.535µs 5.610µs 2.57% 0.667 -0.045 0.62% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.466µs; 5.476µs] or [-0.086%; +0.086%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 298.915µs 302.250µs ± 1.164µs 302.283µs ± 0.670µs 302.939µs 304.168µs 304.897µs 305.788µs 1.16% -0.083 0.314 0.38% 0.082µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3270234.759op/s 3308570.940op/s ± 12742.074op/s 3308163.722op/s ± 7333.825op/s 3315627.887op/s 3329064.693op/s 3339793.299op/s 3345433.063op/s 1.13% 0.110 0.315 0.38% 901.001op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.087µs 27.343µs ± 0.172µs 27.317µs ± 0.084µs 27.415µs 27.519µs 28.136µs 28.691µs 5.03% 3.894 24.913 0.63% 0.012µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 34854355.267op/s 36574259.131op/s ± 225173.861op/s 36607515.400op/s ± 113526.396op/s 36700557.022op/s 36832076.602op/s 36892878.185op/s 36918208.588op/s 0.85% -3.679 22.896 0.61% 15922.196op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.815µs 15.986µs ± 0.133µs 15.939µs ± 0.050µs 16.007µs 16.270µs 16.294µs 16.308µs 2.31% 1.191 0.082 0.83% 0.009µs 1 200
normalization/normalize_name/normalize_name/good throughput 61320362.518op/s 62557846.203op/s ± 516548.785op/s 62739727.108op/s ± 198138.040op/s 62921143.429op/s 63072068.417op/s 63136029.014op/s 63231245.238op/s 0.78% -1.175 0.053 0.82% 36525.515op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [302.088µs; 302.411µs] or [-0.053%; +0.053%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3306805.011op/s; 3310336.869op/s] or [-0.053%; +0.053%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.319µs; 27.367µs] or [-0.087%; +0.087%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36543052.200op/s; 36605466.063op/s] or [-0.085%; +0.085%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.968µs; 16.005µs] or [-0.116%; +0.116%] None None None
normalization/normalize_name/normalize_name/good throughput [62486257.509op/s; 62629434.896op/s] or [-0.114%; +0.114%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 19.262µs 30.064µs ± 18.524µs 19.551µs ± 0.232µs 38.400µs 49.287µs 95.809µs 187.382µs 858.43% 5.014 35.943 61.46% 1.310µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [27.496µs; 32.631µs] or [-8.539%; +8.539%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.153ms 58.772ms ± 0.336ms 58.827ms ± 0.265ms 59.032ms 59.206ms 59.507ms 59.950ms 1.91% 0.084 -0.551 0.57% 0.024ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.726ms; 58.819ms] or [-0.079%; +0.079%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 65.753µs 65.956µs ± 0.137µs 65.935µs ± 0.049µs 65.992µs 66.089µs 66.356µs 67.359µs 2.16% 6.216 56.266 0.21% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [65.937µs; 65.975µs] or [-0.029%; +0.029%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.345ms 6.364ms ± 0.015ms 6.361ms ± 0.005ms 6.368ms 6.381ms 6.441ms 6.445ms 1.32% 3.494 14.609 0.24% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.362ms; 6.366ms] or [-0.033%; +0.033%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 138.235µs 139.034µs ± 0.351µs 138.986µs ± 0.157µs 139.148µs 139.635µs 140.423µs 141.302µs 1.67% 2.257 10.302 0.25% 0.025µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [138.986µs; 139.083µs] or [-0.035%; +0.035%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.463µs 38.034µs ± 0.889µs 37.626µs ± 0.073µs 37.776µs 39.931µs 39.954µs 40.851µs 8.57% 1.700 1.021 2.33% 0.063µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.911µs; 38.158µs] or [-0.324%; +0.324%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a9b35eb 1737058360 fix-resource-tag
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 543.655µs 545.289µs ± 1.103µs 545.054µs ± 0.531µs 545.634µs 547.915µs 548.454µs 550.128µs 0.93% 1.629 3.277 0.20% 0.078µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1817757.331op/s 1833898.346op/s ± 3697.904op/s 1834679.549op/s ± 1787.062op/s 1836306.476op/s 1838030.490op/s 1838621.686op/s 1839402.038op/s 0.26% -1.614 3.207 0.20% 261.481op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 475.054µs 475.992µs ± 0.328µs 475.943µs ± 0.181µs 476.162µs 476.585µs 476.840µs 477.214µs 0.27% 0.587 1.150 0.07% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2095496.634op/s 2100877.022op/s ± 1445.880op/s 2101093.215op/s ± 799.345op/s 2101834.489op/s 2102879.506op/s 2104499.284op/s 2105024.783op/s 0.19% -0.581 1.143 0.07% 102.239op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 194.438µs 194.954µs ± 0.346µs 194.933µs ± 0.171µs 195.086µs 195.366µs 195.426µs 198.554µs 1.86% 5.680 56.709 0.18% 0.024µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5036407.260op/s 5129422.518op/s ± 9012.324op/s 5129954.921op/s ± 4500.091op/s 5134629.652op/s 5138740.517op/s 5140824.298op/s 5143015.068op/s 0.25% -5.541 54.806 0.18% 637.268op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.827µs 47.264µs ± 0.169µs 47.258µs ± 0.110µs 47.372µs 47.562µs 47.696µs 47.825µs 1.20% 0.408 0.335 0.36% 0.012µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20909369.701op/s 21158114.275op/s ± 75511.376op/s 21160564.987op/s ± 49217.749op/s 21206335.459op/s 21271551.868op/s 21307203.612op/s 21355095.310op/s 0.92% -0.385 0.306 0.36% 5339.461op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.950µs 50.210µs ± 0.104µs 50.216µs ± 0.056µs 50.260µs 50.353µs 50.418µs 50.968µs 1.50% 1.698 13.240 0.21% 0.007µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19620001.633op/s 19916417.318op/s ± 41059.859op/s 19913992.393op/s ± 22121.139op/s 19939506.795op/s 19982794.875op/s 20009339.837op/s 20019861.565op/s 0.53% -1.623 12.642 0.21% 2903.370op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [545.136µs; 545.442µs] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1833385.852op/s; 1834410.840op/s] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [475.946µs; 476.037µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2100676.637op/s; 2101077.407op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.906µs; 195.002µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5128173.497op/s; 5130671.540op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.240µs; 47.287µs] or [-0.050%; +0.050%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21147649.124op/s; 21168579.425op/s] or [-0.049%; +0.049%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.196µs; 50.224µs] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19910726.817op/s; 19922107.820op/s] or [-0.029%; +0.029%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (b64c404) to head (a9b35eb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   71.01%   70.97%   -0.04%     
==========================================
  Files         319      319              
  Lines       46768    46780      +12     
==========================================
- Hits        33210    33201       -9     
- Misses      13558    13579      +21
Components Coverage Δ
crashtracker 38.00% <ø> (ø)
crashtracker-ffi 5.63% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.71% <ø> (ø)
data-pipeline-ffi 90.08% <ø> (ø)
ddcommon 80.24% <ø> (ø)
ddcommon-ffi 62.11% <ø> (ø)
ddtelemetry 59.51% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 88.94% <66.66%> (-0.48%) ⬇️
dogstatsd-client 79.77% <ø> (ø)
ipc 82.69% <ø> (ø)
profiling 84.29% <ø> (ø)
profiling-ffi 77.55% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.91% <ø> (ø)
sidecar-ffi 3.98% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.79% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanista duncanista duncanista left review comments

@tobz tobz Awaiting requested review from tobz

@duncanpharvey duncanpharvey Awaiting requested review from duncanpharvey

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgallotta @codecov-commenter @duncanista