Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(injector: builtin: sql): driver is not registered from non-instrumented sql calls #411

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

eliottness
Copy link
Contributor

gopkg.in/DataDog/dd-trace-go.v1/contrib/database/sql.Register actually does not call database/sql.Register under the hood so we have to do it ourselves

@eliottness eliottness force-pushed the eliottness/register-driver-still branch from b5f19dc to 13281aa Compare November 20, 2024 17:18
@eliottness eliottness marked this pull request as ready for review November 22, 2024 10:32
@eliottness eliottness requested a review from a team as a code owner November 22, 2024 10:32
@RomainMuller RomainMuller requested a review from a team as a code owner November 22, 2024 10:32
@eliottness eliottness added this pull request to the merge queue Nov 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 22, 2024
@eliottness eliottness added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit f0fee1a Nov 22, 2024
38 checks passed
@eliottness eliottness deleted the eliottness/register-driver-still branch November 22, 2024 14:57
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.66%. Comparing base (a8237ee) to head (b54d49a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   64.23%   63.66%   -0.57%     
==========================================
  Files         185      185              
  Lines       11087    11095       +8     
==========================================
- Hits         7122     7064      -58     
- Misses       3420     3507      +87     
+ Partials      545      524      -21     
Components Coverage Δ
Generators 78.12% <ø> (ø)
Instruments 73.41% <ø> (ø)
Go Driver 80.16% <ø> (ø)
Toolexec Driver 74.00% <ø> (ø)
Aspects 74.10% <ø> (ø)
Injector 74.97% <ø> (ø)
Job Server 68.18% <ø> (-5.28%) ⬇️
Integration Test Suite 57.20% <100.00%> (+0.05%) ⬆️
Other 63.66% <100.00%> (-0.57%) ⬇️
Files with missing lines Coverage Δ
_integration-tests/tests/sql/sql.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants