Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_integration_azure] Add app_service_plan_filters, cspm, and custom metrics #2059

Merged
merged 11 commits into from
Aug 17, 2023

Conversation

ava-silver
Copy link
Contributor

@ava-silver ava-silver commented Aug 14, 2023

Update the azure integration terraform resources to take in new settings now available in the API: app_service_plan_filters, cspm_enabled, and use_custom_metrics.

AZI-492

@ava-silver ava-silver marked this pull request as ready for review August 16, 2023 14:20
@ava-silver ava-silver requested review from a team as code owners August 16, 2023 14:20
@ava-silver ava-silver changed the title [AZI-492] Add app_service_plan_filters, cspm, and custom metrics [datadog_integration_azure] Add app_service_plan_filters, cspm, and custom metrics Aug 16, 2023
@therve therve force-pushed the ava.silver/azi-492/add-asp-filters-cspm-custom-metrics branch from 894213e to 4de433f Compare August 16, 2023 15:20
@ava-silver ava-silver requested a review from a team August 16, 2023 17:39
buraizu
buraizu previously approved these changes Aug 16, 2023
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good from a docs perspective with one minor update per the documentation style guide. I also created DOCS-6075 in Jira to follow up on other parts of the doc that may need updating.

docs/resources/integration_azure.md Outdated Show resolved Hide resolved
@nkzou nkzou merged commit 4342371 into master Aug 17, 2023
8 checks passed
@nkzou nkzou deleted the ava.silver/azi-492/add-asp-filters-cspm-custom-metrics branch August 17, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants