-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datadog_integration_azure] Add app_service_plan_filters, cspm, and custom metrics #2059
Merged
nkzou
merged 11 commits into
master
from
ava.silver/azi-492/add-asp-filters-cspm-custom-metrics
Aug 17, 2023
Merged
[datadog_integration_azure] Add app_service_plan_filters, cspm, and custom metrics #2059
nkzou
merged 11 commits into
master
from
ava.silver/azi-492/add-asp-filters-cspm-custom-metrics
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ava-silver
changed the title
[AZI-492] Add app_service_plan_filters, cspm, and custom metrics
[datadog_integration_azure] Add app_service_plan_filters, cspm, and custom metrics
Aug 16, 2023
therve
force-pushed
the
ava.silver/azi-492/add-asp-filters-cspm-custom-metrics
branch
from
August 16, 2023 15:20
894213e
to
4de433f
Compare
buraizu
previously approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good from a docs perspective with one minor update per the documentation style guide. I also created DOCS-6075 in Jira to follow up on other parts of the doc that may need updating.
Co-authored-by: Bryce Eadie <[email protected]>
nkzou
approved these changes
Aug 17, 2023
nkzou
approved these changes
Aug 17, 2023
nkzou
deleted the
ava.silver/azi-492/add-asp-filters-cspm-custom-metrics
branch
August 17, 2023 20:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the azure integration terraform resources to take in new settings now available in the API: app_service_plan_filters, cspm_enabled, and use_custom_metrics.
AZI-492