[datadog_apm_retention_filter] Support updating default retention filters #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SalahEddineBC
changed the title
SalahEddineBC
force-pushed
the
salah.bachircherif/update-retention-filters-resource
branch
from
c1d4793
to
8c6d657
Compare
skarimo
reviewed
May 21, 2024
| var id string | ||
| var filterName string | ||
| for _, rfa := range resp.Data { | ||
| if string(rfa.Attributes.GetFilterType()) == state.FilterType.ValueString() { |
There was a problem hiding this comment.
Why are we matching my filter type here? Can't we have multiple default pipelines with the same type?
| func (r *ApmRetentionFilterResource) Create(ctx context.Context, request resource.CreateRequest, response *resource.CreateResponse) { | ||
| var state ApmRetentionFilterModel | ||
| response.Diagnostics.Append(request.Plan.Get(ctx, &state)...) | ||
| if response.Diagnostics.HasError() { | ||
| return | ||
| } | ||
| if state.FilterType.ValueString() != "spans-sampling-processor" { |
There was a problem hiding this comment.
Can default retention rules not have type spans-sampling-processor ? I see Synthetics Default rule has definition:
{
"id": "",
"name": "Synthetics Default",
"enabled": false,
"meta": {
"description": "Get started with Synthetic Monitoring",
"tags": [
"dd.default:true",
"dd.feature:synthetics"
]
},
"type": "spans-sampling-processor"
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where users are unable to define default retention filters as resources, this PR updates
datadog_apm_retention_filterresource to allow defining those filters in terraform.this PR depends on https://github.com/DataDog/datadog-api-spec/pull/2757 to be released