Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_spans_metric] Mark include_percentiles property as computed #2707

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Dec 5, 2024

The property was being set by the provider when the user doesn't set it but is not marked as Computed in the schema. This results in an error on apply:

╷
│ Error: Provider produced inconsistent result after apply
│ 
│ When applying changes to datadog_spans_metric.my_backup_success, provider
│ "provider[\"registry.terraform.io/datadog/datadog\"]" produced an unexpected new value:
│ .compute.include_percentiles: was null, but now cty.False.
│ 
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.
╵
Error: exit status 1

This change fixes that by setting the property as Computed in the schema. Let me know if you have any feedback here!

fixes #2706

@VenelinMartinov
Copy link
Contributor Author

Hey @SalahEddineBC @vitormaco. Do you have any feedback here? I'd love to get this merged if possible!

@SalahEddineBC
Copy link
Contributor

👋 @VenelinMartinov I started taking a look at this, apologies for the delay.

Copy link
Contributor

@SalahEddineBC SalahEddineBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix, I made a small change and updated test files. I will do the merge.

@skarimo skarimo changed the title Fix spans_metric resource include_percentiles property [datadog_spans_metric] Set include_percentiles as computed property Feb 4, 2025
@skarimo skarimo changed the title [datadog_spans_metric] Set include_percentiles as computed property [datadog_spans_metric] Mark include_percentiles property as computed Feb 4, 2025
@skarimo skarimo merged commit 28b7d12 into DataDog:master Feb 4, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spans metric resource is broken when include_percentiles is not set
3 participants