Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dinky classpath add FLINK_HOME #3158

Merged
merged 8 commits into from
Feb 18, 2024
Merged

Conversation

gaoyan1998
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@gaoyan1998 gaoyan1998 added the Optimization Optimization function label Feb 17, 2024
@gaoyan1998 gaoyan1998 added this to the 1.0.0 milestone Feb 17, 2024
@gaoyan1998 gaoyan1998 self-assigned this Feb 17, 2024
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit ce43d24 into DataLinkDC:dev Feb 18, 2024
15 checks passed
gaoyan1998 added a commit to gaoyan1998/dinky that referenced this pull request Mar 19, 2024
@gaoyan1998 gaoyan1998 deleted the fix-auto.sh branch March 31, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization Optimization function
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants