Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] added demo env doc #3213

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

Zzm0809
Copy link
Contributor

@Zzm0809 Zzm0809 commented Mar 1, 2024

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@Zzm0809 Zzm0809 added the Doc Improvements or additions to documentation label Mar 1, 2024
@Zzm0809 Zzm0809 added this to the 1.0.0 milestone Mar 1, 2024
Copy link
Contributor

@gaoyan1998 gaoyan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzm0809 Zzm0809 marked this pull request as draft March 1, 2024 13:00
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzm0809 Zzm0809 marked this pull request as ready for review March 1, 2024 14:47
@Zzm0809 Zzm0809 merged commit 84b1fcd into DataLinkDC:dev Mar 1, 2024
1 check passed
@Zzm0809 Zzm0809 deleted the added-demo-env-doc branch March 4, 2024 04:18
gaoyan1998 pushed a commit to gaoyan1998/dinky that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants