Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization][admin] NULL may be used when optimizing heartbeat detection of cluster instances #3275

Merged

Conversation

czshh0628
Copy link
Contributor

@czshh0628 czshh0628 commented Mar 11, 2024

Purpose of the pull request

close #3274

Brief change log

en: NULL may be used when optimizing heartbeat detection of cluster instances
cn: 优化集群实例心跳检测时可能为空的问题

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@Zzm0809 Zzm0809 added the Optimization Optimization function label Mar 11, 2024
@Zzm0809 Zzm0809 added this to the 1.0.1 milestone Mar 11, 2024
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit 740fd56 into DataLinkDC:dev Mar 11, 2024
13 checks passed
gaoyan1998 pushed a commit to gaoyan1998/dinky that referenced this pull request Mar 19, 2024
leechor pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimization Optimization function
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Optimization][admin] NULL may be used when optimizing heartbeat detection of cluster instances
3 participants