Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization-4165] Optimization udf saved placeholder #4255

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[Optimization-4165] Optimization udf saved placeholder #4255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dinky-admin/src/main/java/org/dinky/controller/TaskController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package org.dinky.controller;

import org.dinky.config.Dialect;
import org.dinky.data.annotations.CheckTaskOwner;
import org.dinky.data.annotations.ExecuteProcess;
import org.dinky.data.annotations.Log;
Expand Down Expand Up @@ -210,6 +211,9 @@ public Result<ObjectNode> getJobPlan(@RequestBody TaskDTO taskDTO) {
@CheckTaskOwner(checkParam = TaskId.class, checkInterface = TaskService.class)
public Result<Void> saveOrUpdateTask(@Validated({Save.class}) @RequestBody TaskSaveDTO task) {
if (taskService.saveOrUpdateTask(task.toTaskEntity())) {
if (Dialect.isUDF(task.getDialect())) {
return Result.succeed(Status.UDF_SAVE_SUCCESS_PLACEHOLDER);
}
return Result.succeed(Status.SAVE_SUCCESS);
} else {
return Result.failed(Status.SAVE_FAILED);
Expand Down
2 changes: 1 addition & 1 deletion dinky-common/src/main/java/org/dinky/data/enums/Status.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ public enum Status {
* udf template
*/
UDF_TEMPLATE_EXIST_RELATIONSHIP(23001, "udf.template.exist.relationship"),

UDF_SAVE_SUCCESS_PLACEHOLDER(23002, "udf.save.success.placeholder"),
/**
* Resource
*/
Expand Down
1 change: 1 addition & 0 deletions dinky-common/src/main/resources/i18n/messages_en_US.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ cluster.instance.not.health=Cluster Instance Status Not Health
cluster.instance.health.not.delete=This cluster instance belongs to automatic registration mode and is in an available state, and deletion is not allowed. Please stop this cluster instance first
cluster.config.exist.relationship=Cluster Config Already Exists Relationship, Can Not Delete
udf.template.exist.relationship=Udf Template Already Exists Relationship, Can Not Delete
udf.save.success.placeholder=The UDF has been saved, please click the [Publish] button to recompile it, otherwise it will not take effect/cannot be used
operate.failed=Operate Failed
test.connection.failed=Test Connection Failed
switching.tenant.success=Select Tenant Success
Expand Down
1 change: 1 addition & 0 deletions dinky-common/src/main/resources/i18n/messages_zh_CN.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ cluster.instance.not.health=集群实例状态不健康
cluster.instance.health.not.delete=该集群实例属于自动注册模式且为可用状态,不允许删除,请先停止该集群实例
cluster.config.exist.relationship=集群配置已存在关联关系,不允许删除
udf.template.exist.relationship=UDF模板已存在关联关系,不允许删除
udf.save.success.placeholder=UDF 已保存，请点击 [发布] 按钮重新编译，否则不会生效/无法使用
operate.failed=操作失败
test.connection.failed=测试连接失败
switching.tenant.success=选择租户成功
Expand Down
Loading