Additional proxy fix and code-refactoring #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Converted all leading spaces into tabs (1 tab = 4 spaces) using `unexpand --tabs=4 --first-only` (smudge) filter. * Removed trailing whitespaces via `([ ]+)\n -> \n` mapping * Cleaned indented empty lines via `^([\t ]+\n -> \n` mapping * Added trailing newline to all files
Note: The difference to ilAdobeConnectXMLAPI->proxy() is that we do *not* set a system-wide xlibml-proxy (libxml_set_streams_context) that might interfere with other parts of the ILIAS ecosystem, but build a request-based proxy-context!
… in ilSwitchAaiXMLAPI
Note: This is also a preparation for replacing curl_init() with centralized curl-handler from ilAdobeConnectServer instead!
…m ilAdobeConnectServer
…alls with centralized getRemoteXML from ilAdobeConnectServer
…or of per-request context in ilAdobeConnectServer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo
uns ist gestern noch ein kleiner Fehler in der Proxy-Implementierung von OnlineArts aufgefallen.
Es fehlte leider die Proxy-Konfiguration für CURL beim upload von Dateien (siehe hier). Dieser PR fixed dies.
Die commits sollten relativ sprechend und sauber formatiert sein, hier aber trotzdem noch mal etwas mehr Informationen:
$context = ...; ... = file_get_contents(); ... = simplexml_load_string(...)Fragmente durch eine sauber gekapselte Implementierung (siehe 9507fc6)libxml_set_streams_context), da er dank 9507fc6 und 97087dc nicht mehr notwendig ist. Somit ist ausgeschlossen, dass hierdurch andere Komponenten im ILIAS Ökosystem durch diese globale/systemweite Einstellung beeinträchtigt werden.Das ganze läuft aktuell auf unserem ILIAS Test- und Produktivsystem ohne Probleme.