[DH-5519] Remove from the error response dict and create a log (#418)

Dataherald · Mar 4, 2024 · 09f65c6 · 09f65c6
1 parent 5e7a5de
commit 09f65c6
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/dataherald/utils/error_codes.py b/dataherald/utils/error_codes.py
@@ -1,5 +1,9 @@
+import logging
+
 from fastapi.responses import JSONResponse
 
+logger = logging.getLogger(__name__)
+
 ERROR_MAPPING = {
     "InvalidId": "invalid_object_id",
     "InvalidDBConnectionError": "invalid_database_connection",
@@ -25,16 +29,20 @@ def __init__(self, message, description=None):
 
 
 def error_response(error, detail: dict, default_error_code=""):
+    error_code = ERROR_MAPPING.get(error.__class__.__name__, default_error_code)
+    description = getattr(error, "description", None)
+    logger.error(
+        f"Error code: {error_code}, message: {error}, description: {description}, detail: {detail}"
+    )
+
+    detail.pop("metadata", None)
+
     return JSONResponse(
         status_code=400,
         content={
-            "error_code": ERROR_MAPPING.get(
-                error.__class__.__name__, default_error_code
-            ),
+            "error_code": error_code,
             "message": str(error),
-            "description": error.description
-            if isinstance(error, CustomError)
-            else None,
+            "description": description,
             "detail": detail,
         },
     )