Skip to content

Commit

Permalink
DH-4823 Improve read the docs documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
jcjc712 committed Oct 13, 2023
1 parent 733e67c commit 69b5533
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 9 deletions.
31 changes: 23 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ We currently support connections to Postgres, BigQuery, Databricks, Snowflake an

#### Connecting through the API

You can define a DB connection through a call to the following API endpoint `/api/v1/database`. For example
You can define a DB connection through a call to the following API endpoint `POST /api/v1/database-connections`. For example

Example 1. Without a SSH connection
```
Expand Down Expand Up @@ -295,7 +295,8 @@ curl -X 'POST' \
```

#### Adding string descriptions
In addition to database table_info and golden_sql, you can add strings describing tables and/or columns to the context store manually from the `PATCH /api/v1/table-descriptions/{table_description_id}` endpoint
In addition to database table_info and golden_sql, you can set descriptions or update the columns per table and column.
All request body fields are optional, and only the fields that are explicitly set will be used to update the resource.

```
curl -X 'PATCH' \
Expand All @@ -307,17 +308,31 @@ curl -X 'PATCH' \
"columns": [
{
"name": "column1",
"description": "Column1 description"
"description": "string",
"is_primary_key": false,
"data_type": "string",
"low_cardinality": true,
"categories": [
"string"
],
"foreign_key": false
},
{
"name": "column2",
"description": "Column2 description"
"description": "string",
"is_primary_key": false,
"data_type": "string",
"low_cardinality": true,
"categories": [
"string"
],
"foreign_key": false
}
]
}'
```

#### adding database level instructions
#### Adding database level instructions

You can add database level instructions to the context store manually from the `POST /api/v1/instructions` endpoint
These instructions are passed directly to the engine and can be used to steer the engine to generate SQL that is more in line with your business logic.
Expand All @@ -333,7 +348,7 @@ curl -X 'POST' \
}'
```

#### getting database level instructions
#### Getting database level instructions

You can get database level instructions from the `GET /api/v1/instructions` endpoint

Expand All @@ -343,7 +358,7 @@ curl -X 'GET' \
-H 'accept: application/json'
```

#### deleting database level instructions
#### Deleting database level instructions

You can delete database level instructions from the `DELETE /api/v1/instructions/{instruction_id}` endpoint

Expand All @@ -353,7 +368,7 @@ curl -X 'DELETE' \
-H 'accept: application/json'
```

#### updating database level instructions
#### Updating database level instructions

You can update database level instructions from the `PUT /api/v1/instructions/{instruction_id}` endpoint
Try different instructions to see how the engine generates SQL
Expand Down
27 changes: 27 additions & 0 deletions docs/api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,33 @@ The related endpoints are:
* :doc:`list_responses <api.list_responses>` -- ``GET api/v1/responses``
* :doc:`get_response <api.get_response>` -- ``GET api/v1/responses/{response_id}``

**Response resource example:**

.. code-block:: json
{
"question_id": "string",
"response": "string",
"intermediate_steps": [
"string"
],
"sql_query": "string",
"sql_query_result": {
"columns": [
"string"
],
"rows": [
{}
]
},
"sql_generation_status": "INVALID",
"error_message": "string",
"exec_time": 0,
"total_tokens": 0,
"total_cost": 0,
"confidence_score": 0,
"created_at": "2023-10-12T16:26:40.951158"
}
Table Descriptions
---------------------
Expand Down
2 changes: 1 addition & 1 deletion docs/api.scan_table_description.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.. api.scan_database:
Scan a Database
Create a table description
=======================

Once you have set your db credentials request this endpoint to scan your database. It maps
Expand Down

0 comments on commit 69b5533

Please sign in to comment.